Skip to content

Commit 5fcc0e5

Browse files
committed
http: replace llhttp with milo
1 parent 7bf29b5 commit 5fcc0e5

File tree

84 files changed

+1520
-1263
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

84 files changed

+1520
-1263
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868

6969
# http
7070

71-
/deps/llhttp/* @nodejs/http @nodejs/net
71+
/deps/milo/* @nodejs/http @nodejs/net
7272
/doc/api/http.md @nodejs/http @nodejs/net
7373
/lib/_http_* @nodejs/http @nodejs/net
7474
/lib/http.js @nodejs/http @nodejs/net

.github/workflows/tools.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ on:
2828
- icu
2929
- libuv
3030
- lint-md-dependencies
31-
- llhttp
31+
- milo
3232
- minimatch
3333
- nghttp2
3434
- nghttp3
@@ -198,11 +198,11 @@ jobs:
198198
cd ../..
199199
make lint-md-rollup
200200
fi
201-
- id: llhttp
201+
- id: milo
202202
subsystem: deps
203203
label: dependencies
204204
run: |
205-
./tools/dep_updaters/update-llhttp.sh > temp-output
205+
./tools/dep_updaters/update-milo.sh > temp-output
206206
cat temp-output
207207
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
208208
rm temp-output

LICENSE

Lines changed: 4 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -696,30 +696,13 @@ The externally maintained libraries used by Node.js are:
696696
license.
697697
"""
698698

699-
- llhttp, located at deps/llhttp, is licensed as follows:
699+
- milo, located at deps/milo, is licensed as follows:
700700
"""
701-
This software is licensed under the MIT License.
701+
Copyright (c) 2023, and above Paolo Insogna and other contributors
702702

703-
Copyright Fedor Indutny, 2018.
703+
Permission to use, copy, modify, and/or distribute this software for any purpose with or without fee is hereby granted, provided that the above copyright notice and this permission notice appear in all copies.
704704

705-
Permission is hereby granted, free of charge, to any person obtaining a
706-
copy of this software and associated documentation files (the
707-
"Software"), to deal in the Software without restriction, including
708-
without limitation the rights to use, copy, modify, merge, publish,
709-
distribute, sublicense, and/or sell copies of the Software, and to permit
710-
persons to whom the Software is furnished to do so, subject to the
711-
following conditions:
712-
713-
The above copyright notice and this permission notice shall be included
714-
in all copies or substantial portions of the Software.
715-
716-
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
717-
OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
718-
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
719-
NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
720-
DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
721-
OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
722-
USE OR OTHER DEALINGS IN THE SOFTWARE.
705+
THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
723706
"""
724707

725708
- corepack, located at deps/corepack, is licensed as follows:

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ with-code-cache test-code-cache:
169169
$(warning '$@' target is a noop)
170170

171171
out/Makefile: config.gypi common.gypi node.gyp \
172-
deps/uv/uv.gyp deps/llhttp/llhttp.gyp deps/zlib/zlib.gyp \
172+
deps/uv/uv.gyp deps/zlib/zlib.gyp \
173173
deps/simdutf/simdutf.gyp deps/ada/ada.gyp \
174174
tools/v8_gypfiles/toolchain.gypi tools/v8_gypfiles/features.gypi \
175175
tools/v8_gypfiles/inspector.gypi tools/v8_gypfiles/v8.gyp

benchmark/http/bench-parser.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ function main({ len, n }) {
2323

2424
bench.start();
2525
for (let i = 0; i < n; i++) {
26-
parser.execute(header, 0, header.length);
26+
parser.execute(header, header.length);
2727
parser.initialize(REQUEST, {});
2828
}
2929
bench.end(n);

deps/milo/libmilo.a

5.37 MB
Binary file not shown.

0 commit comments

Comments
 (0)