Skip to content

Commit 55678db

Browse files
Merge pull request #1519 from stefannikolei/net50
Add net5.0 targetframework
2 parents 954d233 + 78d23c5 commit 55678db

File tree

6 files changed

+32
-6
lines changed

6 files changed

+32
-6
lines changed

.github/workflows/build-and-test.yml

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,18 @@ jobs:
1414
strategy:
1515
matrix:
1616
options:
17+
- os: ubuntu-latest
18+
framework: net5.0
19+
runtime: -x64
20+
codecov: false
21+
- os: macos-latest
22+
framework: net5.0
23+
runtime: -x64
24+
codecov: false
25+
- os: windows-latest
26+
framework: net5.0
27+
runtime: -x64
28+
codecov: false
1729
- os: ubuntu-latest
1830
framework: netcoreapp3.1
1931
runtime: -x64
@@ -67,12 +79,14 @@ jobs:
6779
- name: Build
6880
shell: pwsh
6981
run: ./ci-build.ps1 "${{matrix.options.framework}}"
82+
env:
83+
SIXLABORS_TESTING: True
7084

7185
- name: Test
7286
shell: pwsh
7387
run: ./ci-test.ps1 "${{matrix.options.os}}" "${{matrix.options.framework}}" "${{matrix.options.runtime}}" "${{matrix.options.codecov}}"
7488
env:
75-
CI: True
89+
SIXLABORS_TESTING: True
7690
XUNIT_PATH: .\tests\ImageSharp.Tests # Required for xunit
7791

7892
- name: Export Failed Output

src/ImageSharp/ImageSharp.csproj

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,21 @@
1212
<PackageProjectUrl>$(RepositoryUrl)</PackageProjectUrl>
1313
<PackageTags>Image Resize Crop Gif Jpg Jpeg Bitmap Png Tga NetCore</PackageTags>
1414
<Description>A new, fully featured, fully managed, cross-platform, 2D graphics API for .NET</Description>
15-
<TargetFrameworks>netcoreapp3.1;netcoreapp2.1;netstandard2.1;netstandard2.0;netstandard1.3;net472</TargetFrameworks>
1615
</PropertyGroup>
1716

17+
<Choose>
18+
<When Condition="$(SIXLABORS_TESTING) == true">
19+
<PropertyGroup>
20+
<TargetFrameworks>net5.0;netcoreapp3.1;netcoreapp2.1;netstandard2.1;netstandard2.0;netstandard1.3;net472</TargetFrameworks>
21+
</PropertyGroup>
22+
</When>
23+
<Otherwise>
24+
<PropertyGroup>
25+
<TargetFrameworks>netcoreapp3.1;netcoreapp2.1;netstandard2.1;netstandard2.0;netstandard1.3;net472</TargetFrameworks>
26+
</PropertyGroup>
27+
</Otherwise>
28+
</Choose>
29+
1830
<ItemGroup>
1931
<None Include="..\..\shared-infrastructure\branding\icons\imagesharp\sixlabors.imagesharp.128.png" Pack="true" PackagePath="" />
2032
</ItemGroup>

tests/ImageSharp.Benchmarks/ImageSharp.Benchmarks.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<AssemblyName>ImageSharp.Benchmarks</AssemblyName>
66
<OutputType>Exe</OutputType>
77
<RootNamespace>SixLabors.ImageSharp.Benchmarks</RootNamespace>
8-
<TargetFrameworks>netcoreapp3.1;netcoreapp2.1;net472</TargetFrameworks>
8+
<TargetFrameworks>net5.0;netcoreapp3.1;netcoreapp2.1;net472</TargetFrameworks>
99
<GenerateProgramFile>false</GenerateProgramFile>
1010
<!--Used to hide test project from dotnet test-->
1111
<IsTestProject>false</IsTestProject>

tests/ImageSharp.Tests.ProfilingSandbox/ImageSharp.Tests.ProfilingSandbox.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<Prefer32Bit>false</Prefer32Bit>
99
<RootNamespace>SixLabors.ImageSharp.Tests.ProfilingSandbox</RootNamespace>
1010
<RuntimeIdentifier>win7-x64</RuntimeIdentifier>
11-
<TargetFrameworks>netcoreapp3.1;netcoreapp2.1;net472</TargetFrameworks>
11+
<TargetFrameworks>net5.0;netcoreapp3.1;netcoreapp2.1;net472</TargetFrameworks>
1212
<StartupObject>SixLabors.ImageSharp.Tests.ProfilingSandbox.Program</StartupObject>
1313
<!--Used to hide test project from dotnet test-->
1414
<IsTestProject>false</IsTestProject>

tests/ImageSharp.Tests/ImageSharp.Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<Project Sdk="Microsoft.NET.Sdk">
33

44
<PropertyGroup>
5-
<TargetFrameworks>netcoreapp3.1;netcoreapp2.1;net472</TargetFrameworks>
5+
<TargetFrameworks>net5.0;netcoreapp3.1;netcoreapp2.1;net472</TargetFrameworks>
66
<DebugSymbols>True</DebugSymbols>
77
<AssemblyName>SixLabors.ImageSharp.Tests</AssemblyName>
88
<Platforms>AnyCPU;x64;x86</Platforms>

0 commit comments

Comments
 (0)