Skip to content

Commit 463ce6d

Browse files
author
Mehdy Dara
committed
Merge pull request #411 from Swiip/always-use-vendor-css
Remove the condition on the inclusion of vendor.css
2 parents 79c8da2 + 32dfb71 commit 463ce6d

File tree

2 files changed

+3
-11
lines changed

2 files changed

+3
-11
lines changed

app/templates/src/_index.html

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,16 @@
77
<meta name="viewport" content="width=device-width">
88
<!-- Place favicon.ico and apple-touch-icon.png in the root directory -->
99

10-
<% if (props.ui.key !== 'none') { %>
1110
<!-- build:css({<%= props.paths.tmp %>/serve,<%= props.paths.src %>}) styles/vendor.css -->
1211
<% if (isVendorStylesPreprocessed) { %>
1312
<link rel="stylesheet" href="app/vendor.css">
1413
<% } else if (props.ui.key === 'bootstrap') { %>
1514
<link rel="stylesheet" href="<%= computedPaths.appToBower %>/bower_components/bootstrap/dist/css/bootstrap.css">
1615
<% } %>
1716
<!-- bower:css -->
18-
<!-- run `gulp wiredep` to automaticaly populate bower styles dependencies -->
17+
<!-- run `gulp inject` to automaticaly populate bower styles dependencies -->
1918
<!-- endbower -->
2019
<!-- endbuild -->
21-
<% } %>
2220

2321
<!-- build:css({<%= props.paths.tmp %>/serve,<%= props.paths.src %>}) styles/app.css -->
2422
<!-- inject:css -->
@@ -51,7 +49,7 @@
5149

5250
<!-- build:js(<%= props.paths.src %>) scripts/vendor.js -->
5351
<!-- bower:js -->
54-
<!-- run `gulp wiredep` to automaticaly populate bower script dependencies -->
52+
<!-- run `gulp inject` to automaticaly populate bower script dependencies -->
5553
<!-- endbower -->
5654
<!-- endbuild -->
5755

test/template/test-index-html.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,18 +31,12 @@ describe('gulp-angular index js template', function () {
3131
});
3232

3333
it('should insert the vendor build block depending of data', function() {
34-
model.props.ui.key = 'none';
34+
model.props.ui.key = 'bootstrap';
3535
model.props.paths.src = 'src';
3636
model.props.paths.tmp = 'tmp';
3737
model.computedPaths.appToBower = 'appToBower';
3838
model.isVendorStylesPreprocessed = false;
39-
4039
var result = indexHtml(model);
41-
result.should.not.match(/<!-- build:css\(.*?\) styles\/vendor\.css -->/);
42-
result.should.not.match(/<!-- bower:css/);
43-
44-
model.props.ui.key = 'bootstrap';
45-
result = indexHtml(model);
4640
result.should.match(/<!-- build:css\({tmp\/serve,src}\) styles\/vendor\.css -->/);
4741
result.should.match(/<!-- bower:css/);
4842
result.should.match(/href="appToBower\/bower_components/);

0 commit comments

Comments
 (0)