Skip to content

Commit c769f7c

Browse files
committed
Merge pull request #1009 from getglad/master
Update foundation 5 to foundation-sites 6
2 parents 6eaeb4f + 838fd77 commit c769f7c

File tree

6 files changed

+36
-19
lines changed

6 files changed

+36
-19
lines changed

generators/app/templates/_bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"bootstrap": "~3.3.5",
4242
<% } -%>
4343
<% } if(props.ui.key === 'foundation') { -%>
44-
"foundation": "~5.5.2",
44+
"foundation-sites": "^6.1.2",
4545
<% } if(props.ui.key === 'angular-material') { -%>
4646
"angular-material": "~1.0.0",
4747
"material-design-iconfont": "~0.0.2",

generators/app/templates/src/app/_foundation/__foundation-index.scss

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,14 @@
22
* If you want to override some foundation settings, you have to change values here.
33
* The list of settings values are listed here bower_components/foundation/scss/foundation/_settings.scss
44
*/
5-
$topbar-bg-color: #5AADBB;
5+
$topbar-background: #5AADBB;
66

77
/**
88
* The import of foundation is made manually because there is still no links of the
99
* sass version in their bower.json...
1010
*/
11-
@import '../<%- computedPaths.appToBower %>/bower_components/foundation/scss/foundation';
11+
@import '../../bower_components/foundation-sites/scss/foundation';
12+
@include foundation-everything;
1213

1314
/**
1415
* Do not remove the comments below. It's the markers used by wiredep to inject
@@ -28,7 +29,7 @@ $topbar-bg-color: #5AADBB;
2829
margin-top: 50px;
2930
}
3031

31-
.th {
32+
.thumbnail {
3233
width: 100%;
3334
height: 200px;
3435

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,18 @@
1-
<nav class="top-bar row">
2-
<ul class="title-area">
1+
<div class="top-bar">
2+
<ul class="top-bar-title menu">
33
<li class="name">
44
<h1><a href="https://github.com/Swiip/generator-gulp-angular">Gulp & Angular</a></h1>
55
</li>
66
</ul>
77

8-
<section class="top-bar-section">
9-
<ul class="right">
8+
<section class="top-bar-right">
9+
<ul class="menu">
10+
<li class="acme-navbar-text">
11+
Application was created {{ vm.relativeDate }}.
12+
</li>
1013
<li class="active"><a ng-href="#">Home</a></li>
1114
<li><a ng-href="#">About</a></li>
1215
<li><a ng-href="#">Contact</a></li>
1316
</ul>
14-
<p class="acme-navbar-text">Application was created {{ vm.relativeDate }}.</p>
1517
</section>
16-
</nav>
18+
</div>
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
11
.acme-navbar-text{
22
color: white;
33
}
4+
5+
a {
6+
color: black;
7+
}
8+
9+
h1 {
10+
font-size: 2em;
11+
margin: 0;
12+
line-height: 1.25em;
13+
}
14+
15+
a:hover, a:focus {
16+
color: greenyellow;
17+
}

generators/app/templates/src/app/main/__foundation.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
<h1>'Allo, 'Allo!</h1>
1111
<img src="assets/images/yeoman.png" alt="I'm Yeoman"><br>
1212
<p>Always a pleasure scaffolding your apps.</p>
13-
<p class="animated infinite" ng-class="main.classAnimation">
14-
<a href="#" class="button success" ng-click="main.showToastr()">Splendid Toastr</a>
13+
<p>
14+
<a href="#" class="button success animated infinite" ng-class="main.classAnimation" ng-click="main.showToastr()">Splendid Toastr</a>
1515
</p>
1616
<p>
1717
With ♥ thanks to the contributions of<acme-malarkey extra-values="['Yeoman', 'Gulp', 'Angular']"></acme-malarkey>
@@ -22,7 +22,7 @@ <h1>'Allo, 'Allo!</h1>
2222

2323
<div class="row">
2424
<div class="large-4 columns" ng-repeat="awesomeThing in main.awesomeThings | orderBy:'rank'">
25-
<div class="th">
25+
<div class="thumbnail">
2626
<img class="right" ng-src="assets/images/{{ awesomeThing.logo }}" alt="{{ awesomeThing.title }}">
2727
<div class="caption">
2828
<h3>{{ awesomeThing.title }}</h3>

test/template/test-bower.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ describe('gulp-angular bower template', function () {
140140
model.props.cssPreprocessor.extension = 'scss';
141141
var result = bower(model);
142142
result.should.not.match(/bootstrap/);
143-
result.should.not.match(/foundation/);
143+
result.should.not.match(/foundation-sites/);
144144
result.should.not.match(/angular-material/);
145145
result.should.not.match(/material-design-lite/);
146146
result.should.not.match(/material-design-iconfont/);
@@ -150,7 +150,7 @@ describe('gulp-angular bower template', function () {
150150
result.should.match(/angular-material/);
151151
result.should.match(/material-design-iconfont/);
152152
result.should.not.match(/boostrap/);
153-
result.should.not.match(/foundation/);
153+
result.should.not.match(/foundation-sites/);
154154
result.should.not.match(/material-design-lite/);
155155

156156
model.props.ui.key = 'material-design-lite';
@@ -159,15 +159,15 @@ describe('gulp-angular bower template', function () {
159159
result.should.match(/material-design-iconfont/);
160160
result.should.not.match(/boostrap/);
161161
result.should.not.match(/angular-material/);
162-
result.should.not.match(/foundation/);
162+
result.should.not.match(/foundation-sites/);
163163

164164
model.props.ui.key = 'bootstrap';
165165
model.props.bootstrapComponents.key = 'ui-bootstrap';
166166
result = bower(model);
167167
result.should.match(/bootstrap-sass/);
168168
result.should.match(/angular-bootstrap/);
169169
result.should.not.match(/"bootstrap"/);
170-
result.should.not.match(/foundation/);
170+
result.should.not.match(/foundation-sites/);
171171
result.should.not.match(/angular-material/);
172172
result.should.not.match(/material-design-lite/);
173173
result.should.not.match(/material-design-iconfont/);
@@ -177,7 +177,7 @@ describe('gulp-angular bower template', function () {
177177
result = bower(model);
178178
result.should.match(/"bootstrap"/);
179179
result.should.match(/angular-strap/);
180-
result.should.not.match(/foundation/);
180+
result.should.not.match(/foundation-sites/);
181181
result.should.not.match(/angular-material/);
182182
result.should.not.match(/material-design-lite/);
183183
result.should.not.match(/material-design-iconfont/);
@@ -186,7 +186,7 @@ describe('gulp-angular bower template', function () {
186186
model.props.cssPreprocessor.extension = 'styl';
187187
result = bower(model);
188188
result.should.match(/bootstrap-stylus/);
189-
result.should.not.match(/foundation/);
189+
result.should.not.match(/foundation-sites/);
190190
result.should.not.match(/angular-material/);
191191
result.should.not.match(/material-design-lite/);
192192
result.should.not.match(/material-design-iconfont/);

0 commit comments

Comments
 (0)