Skip to content

Commit f4d146a

Browse files
committed
adds constructor declaration for the rest of the parameters and allows constructor vars in tslint
1 parent 3bad394 commit f4d146a

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

generators/app/templates/src/app/components/malarkey/_malarkey.directive.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -55,16 +55,11 @@ export interface IContributor {
5555
/** @ngInject */
5656
export class MalarkeyController {
5757
public contributors: any[];
58-
public malarkey: any;
5958

60-
private githubContributor: GithubContributor;
6159

62-
constructor(private $log: angular.ILogService, githubContributor: GithubContributor, malarkey: any) {
60+
constructor(private $log: angular.ILogService, private githubContributor: GithubContributor, private malarkey: any) {
6361
this.contributors = [];
6462

65-
this.githubContributor = githubContributor;
66-
this.malarkey = malarkey;
67-
6863
this.activate();
6964
}
7065

generators/app/templates/tslint.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
"trace"
3535
],
3636
"no-construct": true,
37-
"no-constructor-vars": true,
37+
"no-constructor-vars": false,
3838
"no-debugger": true,
3939
"no-duplicate-key": true,
4040
"no-duplicate-variable": true,

0 commit comments

Comments
 (0)