Skip to content

Improve boilerplate tests #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 7, 2015
Merged

Improve boilerplate tests #745

merged 14 commits into from
Sep 7, 2015

Conversation

@zckrs
Copy link
Collaborator

@zckrs zckrs commented Sep 1, 2015

This PR should:

  • fix warning in TypeScript build (need to rewrite tsd install relative to bower.json to include TypeScript definitions)
  • provide more test

@Swiip
Copy link
Owner

Swiip commented Sep 2, 2015

For me it's not only about TS, but could be the work of having all tests in all languages.

zckrs
zckrs reviewed Sep 2, 2015
View reviewed changes
app/templates/src/app/components/webDevTec/_webDevTec.service.spec.ts Outdated
Copy link
Collaborator Author

@zckrs zckrs Sep 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo 'tect'

@zckrs zckrs changed the title WIP: Fix test typescript WIP: Improve boilerplate tests Sep 3, 2015
@zckrs zckrs force-pushed the fix-test-typescript branch from a954a77 to 9042dfd Compare September 3, 2015 16:26
@zckrs zckrs force-pushed the fix-test-typescript branch 2 times, most recently from ac505f2 to 0743527 Compare September 7, 2015 08:12
@Swiip Swiip changed the title WIP: Improve boilerplate tests Improve boilerplate tests Sep 7, 2015
@Swiip
Copy link
Owner

Swiip commented Sep 7, 2015

All is covered now :)

zckrs pushed a commit that referenced this pull request Sep 7, 2015
Merge pull request #745 from Swiip/fix-test-typescript
ac0f5d8 
Improve boilerplate tests
@zckrs zckrs merged commit ac0f5d8 into master Sep 7, 2015
@Swiip Swiip deleted the fix-test-typescript branch September 9, 2015 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zckrs @Swiip