Added full trailingSlash options testing matrix

Author: paul-sachs

packages/react-router/tests/link.test.tsx

@@ -41,7 +41,7 @@ import {
   getSearchParamsFromURI,
   sleep,
 } from './utils'
-import type { RouterHistory } from '../src'
+import type { RouterHistory, TrailingSlashOption } from '../src'
 
 const ioObserveMock = vi.fn()
 const ioDisconnectMock = vi.fn()
@@ -5550,10 +5550,10 @@ describe.each([{ basepath: '' }, { basepath: '/basepath' }])(
 )
 
 describe("splat routes with empty splat", () => {
-  test.each([{ trailingSlash: true }, { trailingSlash: false }])(
+  test.each([{ trailingSlash: "preserve" as TrailingSlashOption }, { trailingSlash: "always" as TrailingSlashOption }, { trailingSlash: "never" as TrailingSlashOption }])(
     'should handle empty _splat parameter with trailingSlash: $trailingSlash',
     async ({ trailingSlash }) => {
-      const tail = trailingSlash ? '/' : ''
+      const tail = trailingSlash === "always" ? '/' : ''
 
       const rootRoute = createRootRoute()
       const indexRoute = createRoute({
@@ -5605,7 +5605,7 @@ describe("splat routes with empty splat", () => {
       const router = createRouter({
         routeTree: rootRoute.addChildren([indexRoute, splatRoute]),
         history,
-        trailingSlash: trailingSlash ? 'always' : 'never',
+        trailingSlash,
       })
 
       render(<RouterProvider router={router} />)

packages/react-router/tests/navigate.test.tsx

@@ -6,7 +6,7 @@ import {
   createRoute,
   createRouter,
 } from '../src'
-import type { RouterHistory } from '../src'
+import type { RouterHistory, TrailingSlashOption } from '../src'
 
 afterEach(() => {
   vi.clearAllMocks()
@@ -1240,10 +1240,10 @@ describe('router.navigate navigation using optional path parameters - edge cases
 })
 
 describe('splat routes with empty splat', () => {
-  it.each([{ trailingSlash: true }, { trailingSlash: false }])(
+  it.each([{ trailingSlash: "preserve" as TrailingSlashOption }, { trailingSlash: "always" as TrailingSlashOption }, { trailingSlash: "never" as TrailingSlashOption }])(
     'should handle empty _splat parameter with trailingSlash: $trailingSlash',
     async ({ trailingSlash }) => {
-      const tail = trailingSlash ? '/' : ''
+      const tail = trailingSlash === "always" ? '/' : ''
 
       const history = createMemoryHistory({ initialEntries: ['/'] })
 
@@ -1261,7 +1261,7 @@ describe('splat routes with empty splat', () => {
       const router = createRouter({
         routeTree: rootRoute.addChildren([indexRoute, splatRoute]),
         history,
-        trailingSlash: trailingSlash ? 'always' : 'never',
+        trailingSlash,
       })
 
       await router.load()

packages/react-router/tests/useNavigate.test.tsx

@@ -23,7 +23,7 @@ import {
   useNavigate,
   useParams,
 } from '../src'
-import type { RouterHistory } from '../src'
+import type { RouterHistory, TrailingSlashOption } from '../src'
 
 let history: RouterHistory
 
@@ -2557,10 +2557,10 @@ describe.each([{ basepath: '' }, { basepath: '/basepath' }])(
 )
 
 describe('splat routes with empty splat', () => {
-  test.each([{ trailingSlash: true }, { trailingSlash: false }])(
+  test.each([{ trailingSlash: "preserve" as TrailingSlashOption }, { trailingSlash: "always" as TrailingSlashOption }, { trailingSlash: "never" as TrailingSlashOption }])(
     'should handle empty _splat parameter with trailingSlash: $trailingSlash',
     async ({ trailingSlash }) => {
-      const tail = trailingSlash ? '/' : ''
+      const tail = trailingSlash === "always" ? '/' : ''
 
       const rootRoute = createRootRoute()
       const indexRoute = createRoute({
@@ -2623,7 +2623,7 @@ describe('splat routes with empty splat', () => {
       const router = createRouter({
         routeTree: rootRoute.addChildren([indexRoute, splatRoute]),
         history,
-        trailingSlash: trailingSlash ? 'always' : 'never',
+        trailingSlash,
       })
 
       render(<RouterProvider router={router} />)