Correct default parameter for LNT and test results endpoint

Author: tuvshuud

telq/endpoints/__init__.py

@@ -71,7 +71,7 @@ class ResultsURL(TelQURL):
     """Endpoint for results"""
 
     def path(self, test_id) -> str:
-        return f"/results/{test_id}"
+        return f"/tests/{test_id}"
 
 
 class BatchResultsURL(TelQURL):

telq/tests/lnt.py

@@ -23,18 +23,18 @@ class LNT(TelQRest):
     def initiate_new_tests(
         self,
         tests: List[Test],
+        smppValidityPeriod: Optional[int] = None,
+        dataCoding: Optional[str] = None,
+        sourceTon: Optional[str] = None,
+        sourceNpi: Optional[str] = None,
         resultsCallbackUrl: Union[str, None] = None,
         resultsCallbackToken: Optional[str] = None,
         maxCallbackRetries: int = 3,
-        dataCoding: str = "01",
-        sourceTon: str = "00",
-        sourceNpi: str = "12",
         testTimeToLiveInSeconds: int = 3600,
-        smppValidityPeriod: int = 60,
         scheduledDeliveryTime: Optional[str] = None,
-        replaceIfPresentFlag: int = 0,
+        replaceIfPresentFlag: bool = False,
         priorityFlag: int = 1,
-        sendTextAsMessagePayloadTlv: int = 0,
+        sendTextAsMessagePayloadTlv: bool = False,
         commentText: Optional[str] = None,
         tlv: Optional[List[Dict[str, str]]] = None,
         udh: Optional[List[Dict[str, str]]] = None,
@@ -108,13 +108,13 @@ def initiate_new_tests(
 
         data = self._validate_parse_data(
             tests,
-            resultsCallbackUrl,
-            maxCallbackRetries,
+            smppValidityPeriod,
             dataCoding,
             sourceTon,
             sourceNpi,
+            resultsCallbackUrl,
+            maxCallbackRetries,
             testTimeToLiveInSeconds,
-            smppValidityPeriod,
             scheduledDeliveryTime,
             replaceIfPresentFlag,
             priorityFlag,
@@ -136,20 +136,20 @@ def get_test_results(self, date_from: Optional[str] = None, date_to: Optional[st
     def _validate_parse_data(
         self,
         tests: List[Test],
-        resultsCallbackUrl: Union[str, None],
-        maxCallbackRetries: int,
-        dataCoding: str,
-        sourceTon: str,
-        sourceNpi: str,
-        testTimeToLiveInSeconds: int,
-        smppValidityPeriod: int,
-        scheduledDeliveryTime: Optional[str],
-        replaceIfPresentFlag: int,
-        priorityFlag: int,
-        sendTextAsMessagePayloadTlv: int,
-        commentText: Optional[str],
-        tlv: Optional[List[Dict[str, str]]],
-        udh: Optional[List[Dict[str, str]]]
+        smppValidityPeriod: Optional[int] = None,
+        dataCoding: Optional[str] = None,
+        sourceTon: Optional[str] = None,
+        sourceNpi: Optional[str] = None,
+        resultsCallbackUrl: Union[str, None] = None,
+        maxCallbackRetries: int = 3,
+        testTimeToLiveInSeconds: int = 3600,
+        scheduledDeliveryTime: Optional[str] = None,
+        replaceIfPresentFlag: bool = False,
+        priorityFlag: int = 1,
+        sendTextAsMessagePayloadTlv: bool = False,
+        commentText: Optional[str] = None,
+        tlv: Optional[List[Dict[str, str]]] = None,
+        udh: Optional[List[Dict[str, str]]] = None,
     ) -> Dict[str, str]:
         if len(tests) == 0:
             raise KeyError(

test/test_endpoints.py

@@ -62,7 +62,7 @@ def test_results_url_1():
 
 def test_results_url_2():
     actual = endpoints.ResultsURL(base_url=BASE_URL, api_version="v1.5").url(test_id=908)
-    expected = f"{BASE_URL}/v1.5/client/results/908"
+    expected = f"{BASE_URL}/v1.5/client/tests/908"
     message = (
         f"API version v1.5 results endpoint received {actual} instead of {expected}"
     )

test/test_telqtele.py

@@ -55,7 +55,8 @@ def test_tests_1(telq_api: TelQTelecomAPI):
         }
     ]
 
-    telq_api.mt.initiate_new_tests(single_network)
+    response = telq_api.mt.initiate_new_tests(single_network)
+    telq_api.mt.get_test_results(int(response.get('response', [])[0].get('id', 0)))
     assert True