Theme Change #1
TorontoMedia
announced in
Announcements
Replies: 1 comment 1 reply
-
Thank you for working on the website. In general, this task list looks good. I'm okay with the theme change as well. There is a lot of stale/unnecessary information on the website. This would also be good opportunity to remove a bunch of that. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Branch: main
Demo url: https://torontomedia.github.io/firewalld.github.io/
Blog url(nav link should resolve when using firewall.org with no baseurl): https://torontomedia.github.io/firewalld.github.io/blog/
Visual Changes (besides the major theme change)
Terse Task List (listed in no particular order)
site.base_url
to blog post assets to handle different deployment methods.assets/
directory_config.yml
Area of Concerns
bash bundle exec jekyll build --baseurl "${{ steps.pages.outputs.base_path }}"
external_nav
link is defined in_config.yml
to add a link to the Blog in the sidebar navigation. This causes it to appear at the end of the list. While we could create a redirect page pointing toblog/index.html
to control its position in the navigation order, I don’t see a strong reason to change it.Beta Was this translation helpful? Give feedback.
All reactions