Skip to content

fix: Block update removing children when setting content #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2024
Merged

fix: Block update removing children when setting content #1103

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee95c19
Fixed block update removing children when setting content
matthewlipski Sep 25, 2024
7ecfd4c
Added tests
matthewlipski Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/pm-nodes/BlockContainer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ export const BlockContainer = Node.create<{
state.tr
.replaceWith(
startPos,
endPos,
startPos + contentNode.nodeSize,
state.schema.nodes[newType].create(
{
...contentNode.attrs,
Expand Down
Loading