gracefully handle error thrown from the service

Author: phryneas

CHANGELOG.md

@@ -1,3 +1,7 @@
+## v1.0.4
+
+* [gracefully handle error thrown from the service](https://github.com/Realytics/fork-ts-checker-webpack-plugin/pull/249)
+
 ## v1.0.3
 
 * [use worker-rpc library for inter-process communication](https://github.com/Realytics/fork-ts-checker-webpack-plugin/pull/231)

package.json

@@ -1,6 +1,6 @@
 {
   "name": "fork-ts-checker-webpack-plugin",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "description": "Runs typescript type checker and linter on separate process.",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",

src/NormalizedMessage.ts

@@ -1,4 +1,4 @@
-export type ErrorType = 'diagnostic' | 'lint';
+export type ErrorType = 'diagnostic' | 'lint' | 'internal';
 export type Severity = 'error' | 'warning';
 
 interface NormalizedMessageJson {
@@ -9,11 +9,13 @@ interface NormalizedMessageJson {
   file?: string;
   line?: number;
   character?: number;
+  stack?: string;
 }
 
 export class NormalizedMessage {
   public static readonly TYPE_DIAGNOSTIC: ErrorType = 'diagnostic';
   public static readonly TYPE_LINT: ErrorType = 'lint';
+  public static readonly TYPE_INTERNAL: ErrorType = 'internal';
 
   // severity types
   public static readonly SEVERITY_ERROR: Severity = 'error';
@@ -26,6 +28,7 @@ export class NormalizedMessage {
   public readonly file?: string;
   public readonly line?: number;
   public readonly character?: number;
+  public readonly stack?: string;
 
   constructor(data: NormalizedMessageJson) {
     this.type = data.type;
@@ -35,6 +38,7 @@ export class NormalizedMessage {
     this.file = data.file;
     this.line = data.line;
     this.character = data.character;
+    this.stack = data.stack;
   }
 
   public static createFromJSON(json: NormalizedMessageJson) {
@@ -73,6 +77,10 @@ export class NormalizedMessage {
         messageA.content,
         messageB.content
       ) ||
+      NormalizedMessage.compareOptionalStrings(
+        messageA.stack,
+        messageB.stack
+      ) ||
       0 /* EqualTo */
     );
   }
@@ -149,7 +157,8 @@ export class NormalizedMessage {
       content: this.content,
       file: this.file,
       line: this.line,
-      character: this.character
+      character: this.character,
+      stack: this.stack
     } as NormalizedMessageJson;
   }
 
@@ -161,6 +170,10 @@ export class NormalizedMessage {
     return NormalizedMessage.TYPE_LINT === this.type;
   }
 
+  public isInternalType() {
+    return NormalizedMessage.TYPE_INTERNAL === this.type;
+  }
+
   public getFormattedCode() {
     return this.isDiagnosticType() ? 'TS' + this.code : this.code;
   }

src/formatter/codeframeFormatter.ts

@@ -22,6 +22,16 @@ export function createCodeframeFormatter(options: any) {
       : colors.bold.red;
     const positionColor = colors.dim;
 
+    if (message.isInternalType()) {
+      return (
+        messageColor(`INTERNAL ${message.severity.toUpperCase()}: `) +
+        message.content +
+        (message.stack
+          ? os.EOL + 'stack trace:' + os.EOL + colors.gray(message.stack)
+          : '')
+      );
+    }
+
     const file = message.file;
     const source =
       file && FsHelper.existsSync(file) && fs.readFileSync(file, 'utf-8');

src/formatter/defaultFormatter.ts

@@ -19,6 +19,16 @@ export function createDefaultFormatter() {
     const fileAndNumberColor = colors.bold.cyan;
     const codeColor = colors.grey;
 
+    if (message.isInternalType()) {
+      return (
+        messageColor(`INTERNAL ${message.severity.toUpperCase()}: `) +
+        message.content +
+        (message.stack
+          ? os.EOL + 'stack trace:' + os.EOL + colors.gray(message.stack)
+          : '')
+      );
+    }
+
     return [
       messageColor(`${message.severity.toUpperCase()} in `) +
         fileAndNumberColor(

src/service.ts

@@ -64,9 +64,9 @@ async function run(cancellationToken: CancellationToken) {
   let diagnostics: NormalizedMessage[] = [];
   let lints: NormalizedMessage[] = [];
 
-  checker.nextIteration();
-
   try {
+    checker.nextIteration();
+
     diagnostics = await checker.getDiagnostics(cancellationToken);
     if (checker.hasLinter()) {
       lints = checker.getLints(cancellationToken);
@@ -76,7 +76,26 @@ async function run(cancellationToken: CancellationToken) {
       return undefined;
     }
 
-    throw error;
+    diagnostics.push(
+      new NormalizedMessage(
+        error instanceof Error
+          ? {
+              type: NormalizedMessage.TYPE_INTERNAL,
+              severity: NormalizedMessage.SEVERITY_ERROR,
+              code: '',
+              content: error.message,
+              stack: error.stack,
+              file: '[internal]'
+            }
+          : {
+              type: NormalizedMessage.TYPE_INTERNAL,
+              severity: NormalizedMessage.SEVERITY_ERROR,
+              code: '',
+              content: error.toString(),
+              file: '[internal]'
+            }
+      )
+    );
   }
 
   if (cancellationToken.isCancellationRequested()) {