Disable detached sub-process on Windows (#489)

stelcheck · blakeembrey · commit 89d62aa53fc9 · 2017-12-23T10:28:52.000+08:00
diff --git a/src/bin.ts b/src/bin.ts
@@ -62,7 +62,12 @@ v8flags(function (err, v8flags) {
       // are propagated to the process tree, but `kill` is not.
       //
       // See: https://nodejs.org/api/child_process.html#child_process_options_detached
-      detached: true,
+      //
+      // This fix is not being required on Windows; besides, detached mode
+      // runs differently on Windows than on other platforms, and it would break
+      // the behavior of this application. See https://github.com/TypeStrong/ts-node/issues/480
+      // for more details.
+      detached: process.platform !== 'win32',
       stdio: 'inherit'
     }
   )

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,12 @@ v8flags(function (err, v8flags) {`
`62`	`62`	// are propagated to the process tree, but `kill` is not.
`63`	`63`	`//`
`64`	`64`	`// See: https://nodejs.org/api/child_process.html#child_process_options_detached`
`65`		`- detached: true,`
	`65`	`+ //`
	`66`	`+ // This fix is not being required on Windows; besides, detached mode`
	`67`	`+ // runs differently on Windows than on other platforms, and it would break`
	`68`	`+ // the behavior of this application. See https://github.com/TypeStrong/ts-node/issues/480`
	`69`	`+ // for more details.`
	`70`	`+ detached: process.platform !== 'win32',`
`66`	`71`	`stdio: 'inherit'`
`67`	`72`	`}`
`68`	`73`	`)`