Skip to content

Enable malloc_heap.go on JS targets #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2025
Merged

Enable malloc_heap.go on JS targets #66

merged 2 commits into from
Jul 27, 2025

Conversation

@PlasmaPower
Copy link
Contributor

JS doesn't have mmap, so it needs to use the heap malloc backend.

@PlasmaPower PlasmaPower mentioned this pull request Oct 31, 2022
Closed
f41gh7
f41gh7 approved these changes Jul 27, 2025
View reviewed changes
Copy link
Contributor

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f41gh7 f41gh7 merged commit a258637 into VictoriaMetrics:master Jul 27, 2025
@f41gh7
Copy link
Contributor

f41gh7 commented Jul 27, 2025

Thanks for contribution!

@f41gh7 f41gh7 mentioned this pull request Jul 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@f41gh7 f41gh7 f41gh7 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PlasmaPower @f41gh7