Add "publish setup" command #926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarchambault
force-pushed
the
publish
branch
3 times, most recently
from
f3d86f8 to
3142a95
Compare
alexarchambault
force-pushed
the
publish
branch
4 times, most recently
from
a1150f9 to
ae24f28
Compare
alexarchambault
changed the title
alexarchambault
changed the title
alexarchambault
force-pushed
the
publish
branch
5 times, most recently
from
64684a3 to
33c8bc3
Compare
alexarchambault
force-pushed
the
publish
branch
4 times, most recently
from
89c7065 to
1d1c874
Compare
This was referenced May 9, 2022
alexarchambault
force-pushed
the
publish
branch
2 times, most recently
from
67dcbe2 to
3d8548e
Compare
alexarchambault
force-pushed
the
publish
branch
4 times, most recently
from
889efd1 to
9cda952
Compare
romanowski
reviewed
Jul 6, 2022
alexarchambault
force-pushed
the
publish
branch
2 times, most recently
from
c0fce2d to
4f8e33b
Compare
Gedochao
approved these changes
Jul 25, 2022
Contributor
Gedochao
left a comment
Gedochao
left a comment
There was a problem hiding this comment.
Added some NIT comments, none of which should block this PR;
LGTM, although I'd double check if everything works okay after the necessary rebase
modules/cli/src/main/scala/scala/cli/commands/publish/PublishSetup.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/util/SharedOptionsUtil.scala
Show resolved
Hide resolved
modules/integration/src/test/scala/scala/cli/integration/PublishSetupTests.scala
Show resolved
Hide resolved
alexarchambault
force-pushed
the
publish
branch
5 times, most recently
from
853f344 to
985060b
Compare
romanowski
approved these changes
Jul 26, 2022
Useful in subsequent commits
Useful in subsequent commits
Seems it sometimes fails for no reason
alexarchambault
force-pushed
the
publish
branch
3 times, most recently
from
1c9aaf8 to
59751d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12.