Skip to content
This repository was archived by the owner on Sep 16, 2022. It is now read-only.

Commit c6c4f7f

Browse files
committed
Remove model-decoded.
1 parent 029df68 commit c6c4f7f

File tree

4 files changed

+4
-46
lines changed

4 files changed

+4
-46
lines changed

backend/device_registry/api_views.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,6 @@ def get(self, request, *args, **kwargs):
197197
metadata['device_id'] = request.device_id
198198
metadata['manufacturer'] = device.deviceinfo.device_manufacturer
199199
metadata['model'] = device.deviceinfo.device_model
200-
metadata['model-decoded'] = device.deviceinfo.get_model()
201200
else:
202201
metadata = {}
203202
return Response(metadata)

backend/device_registry/models.py

Lines changed: 1 addition & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -320,50 +320,12 @@ class DeviceInfo(models.Model):
320320
detected_mirai = models.BooleanField(default=False, blank=True)
321321
device_metadata = JSONField(blank=True, default=dict)
322322

323-
RASPBERRY_MODEL_MAP = {
324-
'0002': 'Model B Rev 1',
325-
'0003': 'Model B Rev 1',
326-
'0004': 'Model B Rev 2',
327-
'0005': 'Model B Rev 2',
328-
'0006': 'Model B Rev 2',
329-
'0007': 'Model A',
330-
'0008': 'Model A',
331-
'0009': 'Model A',
332-
'000d': 'Model B Rev 2',
333-
'000e': 'Model B Rev 2',
334-
'000f': 'Model B Rev 2',
335-
'0010': 'Model B+',
336-
'0013': 'Model B+',
337-
'900032': 'Model B+',
338-
'0011': 'Compute Module',
339-
'0014': 'Compute Module',
340-
'0012': 'Model A+',
341-
'0015': 'Model A+',
342-
'a01041': '2 Model B v1.1',
343-
'a21041': '2 Model B v1.1',
344-
'a22042': '2 Model B v1.2',
345-
'900092': 'Zero v1.2',
346-
'900093': 'Zero v1.3',
347-
'9000c1': 'Zero W',
348-
'a02082': '3 Model B',
349-
'a22082': '3 Model B',
350-
'a32082': '3 Model B',
351-
'a52082': '3 Model B',
352-
'a22083': '3 Model B',
353-
'a020d3': '3 Model B+',
354-
'a03111': '4 Model B',
355-
'b03111': '4 Model B',
356-
'c03111': '4 Model B'
357-
}
358-
359323
def __str__(self):
360324
return self.device.device_id
361325

362326
def get_model(self):
363-
model = None
364327
if self.device_manufacturer == 'Raspberry Pi':
365-
model = self.device_model
366-
return model
328+
return self.device_model
367329

368330
def get_hardware_type(self):
369331
if self.device_manufacturer == 'Raspberry Pi':

backend/device_registry/tests/test_all.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -247,9 +247,7 @@ def test_fixed_issues(self):
247247

248248
def test_get_model(self):
249249
model = self.device_info0.device_model
250-
self.device_info0.device_model = '000d'
251-
self.assertEqual(self.device_info0.get_model(), 'Model B Rev 2')
252-
self.device_info0.device_model = '000D' # case insensitive
250+
self.device_info0.device_model = 'Model B Rev 2'
253251
self.assertEqual(self.device_info0.get_model(), 'Model B Rev 2')
254252
self.device_info0.device_model = model
255253

backend/device_registry/tests/test_api.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -600,7 +600,7 @@ def setUp(self):
600600
self.device_info = DeviceInfo.objects.create(
601601
device=self.device,
602602
device_manufacturer='Raspberry Pi',
603-
device_model='900092',
603+
device_model='Zero v1.2',
604604
device_metadata={"test": "value"}
605605
)
606606
self.headers = {
@@ -615,8 +615,7 @@ def test_get(self):
615615
'test': 'value',
616616
'device_id': 'device0.d.wott-dev.local',
617617
'manufacturer': 'Raspberry Pi',
618-
'model': '900092',
619-
'model-decoded': 'Zero v1.2',
618+
'model': 'Zero v1.2',
620619
'device-name': 'the-device-name'
621620
})
622621

0 commit comments

Comments
 (0)