Skip to content

Commit 2512513

Browse files
oblomov-devoblomov-dev
authored
renaming popups (#173)
1 parent f607aa3 commit 2512513

27 files changed

+123
-115
lines changed

‎src/z2ui5_cl_demo_app_056.clas.abap‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ CLASS z2ui5_cl_demo_app_056 DEFINITION PUBLIC.
2929
METHODS set_data.
3030

3131
PRIVATE SECTION.
32-
DATA mt_range TYPE z2ui5_cl_popup_get_range=>ty_s_result-t_range.
32+
DATA mt_range TYPE z2ui5_cl_pop_get_range=>ty_s_result-t_range.
3333
ENDCLASS.
3434

3535

@@ -62,7 +62,7 @@ CLASS z2ui5_cl_demo_app_056 IMPLEMENTATION.
6262
client->view_model_update( ).
6363

6464
WHEN `FILTER_VALUE_HELP`.
65-
client->nav_app_call( z2ui5_cl_popup_get_range=>factory( mt_range ) ).
65+
client->nav_app_call( z2ui5_cl_pop_get_range=>factory( mt_range ) ).
6666

6767
WHEN 'BACK'.
6868
client->nav_app_leave( client->get_app( client->get( )-s_draft-id_prev_app_stack ) ).
@@ -168,7 +168,7 @@ CLASS z2ui5_cl_demo_app_056 IMPLEMENTATION.
168168

169169
IF client->get( )-check_on_navigated = abap_true.
170170
TRY.
171-
DATA(lo_value_help) = CAST z2ui5_cl_popup_get_range( client->get_app( client->get( )-s_draft-id_prev_app ) ).
171+
DATA(lo_value_help) = CAST z2ui5_cl_pop_get_range( client->get_app( client->get( )-s_draft-id_prev_app ) ).
172172
IF lo_value_help->result( )-check_confirmed = abap_true.
173173
mt_range = lo_value_help->result( )-t_range.
174174
mt_token = z2ui5_cl_util=>filter_get_token_t_by_range_t( mt_range ).

‎src/z2ui5_cl_demo_app_061.clas.abap‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ ENDCLASS.
1616

1717

1818

19-
CLASS z2ui5_cl_demo_app_061 IMPLEMENTATION.
19+
CLASS Z2UI5_CL_DEMO_APP_061 IMPLEMENTATION.
2020

2121

2222
METHOD set_view.
@@ -82,12 +82,12 @@ CLASS z2ui5_cl_demo_app_061 IMPLEMENTATION.
8282
FIELD-SYMBOLS <tab> TYPE table.
8383
ASSIGN t_tab->* TO <tab>.
8484

85-
INSERT VALUE z2ui5_t_core_01( id = 'this is an uuid' timestampl = '2023234243' id_prev = 'previous' )
85+
INSERT VALUE z2ui5_t_01( id = 'this is an uuid' timestampl = '2023234243' id_prev = 'previous' )
8686
INTO TABLE <tab>.
8787

88-
INSERT VALUE z2ui5_t_core_01( id = 'this is an uuid' timestampl = '2023234243' id_prev = 'previous' )
88+
INSERT VALUE z2ui5_t_01( id = 'this is an uuid' timestampl = '2023234243' id_prev = 'previous' )
8989
INTO TABLE <tab>.
90-
INSERT VALUE z2ui5_t_core_01( id = 'this is an uuid' timestampl = '2023234243' id_prev = 'previous' )
90+
INSERT VALUE z2ui5_t_01( id = 'this is an uuid' timestampl = '2023234243' id_prev = 'previous' )
9191
INTO TABLE <tab>.
9292

9393

‎src/z2ui5_cl_demo_app_066.clas.abap‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ CLASS z2ui5_cl_demo_app_066 DEFINITION
4747
DATA mv_ui5_version TYPE string.
4848

4949
DATA mt_messaging TYPE z2ui5_cl_cc_messaging=>ty_t_items.
50-
DATA mt_message_manager TYPE z2ui5_cl_cc_message_manager=>ty_t_items.
50+
DATA mt_message_manager TYPE z2ui5_cl_cc_message_m=>ty_t_items.
5151

5252
PROTECTED SECTION.
5353

@@ -172,7 +172,7 @@ CLASS Z2UI5_CL_DEMO_APP_066 IMPLEMENTATION.
172172
client->view_display(
173173
view->_z2ui5( )->info_frontend( ui5_version = client->_bind_edit( mv_ui5_version ) )->get_parent(
174174
)->_generic( ns = `html` name = `script` )->_cc_plain_xml( z2ui5_cl_cc_messaging=>get_js( ) )->get_parent(
175-
)->_generic( ns = `html` name = `script` )->_cc_plain_xml( z2ui5_cl_cc_message_manager=>get_js( ) )->get_parent(
175+
)->_generic( ns = `html` name = `script` )->_cc_plain_xml( z2ui5_cl_cc_message_m=>get_js( ) )->get_parent(
176176
)->_z2ui5( )->timer( client->_event( `START` )
177177
)->stringify( ) ).
178178

‎src/z2ui5_cl_demo_app_077.clas.abap‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ CLASS Z2UI5_CL_DEMO_APP_077 IMPLEMENTATION.
8585
check_load_cc = abap_true.
8686
z2ui5_set_data( ).
8787
* client->nav_app_call( z2ui5_cl_popup_js_loader=>factory( z2ui5_cl_cc_spreadsheet=>get_js( mv_column_config ) ) ).
88-
client->nav_app_call( z2ui5_cl_popup_js_loader=>factory( z2ui5_cl_cc_spreadsheet=>get_js( ) ) ).
88+
client->nav_app_call( z2ui5_cl_pop_js_loader=>factory( z2ui5_cl_cc_spreadsheet=>get_js( ) ) ).
8989
RETURN.
9090
ELSEIF check_initialized = abap_false.
9191
check_initialized = abap_true.

‎src/z2ui5_cl_demo_app_084.clas.abap‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ CLASS z2ui5_cl_demo_app_084 IMPLEMENTATION.
166166

167167
DATA(view) = z2ui5_cl_xml_view=>factory( ).
168168
client->view_display(
169-
view->_generic( ns = `html` name = `script` )->_cc_plain_xml( z2ui5_cl_cc_message_manager=>get_js( )
169+
view->_generic( ns = `html` name = `script` )->_cc_plain_xml( z2ui5_cl_cc_message_m=>get_js( )
170170
)->_z2ui5( )->timer( client->_event( `ON_CC_LOADED` )
171171
)->stringify( ) ).
172172

‎src/z2ui5_cl_demo_app_090.clas.abap‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ CLASS z2ui5_cl_demo_app_090 IMPLEMENTATION.
8787
IF check_cc_loaded = abap_false.
8888
check_cc_loaded = abap_true.
8989
init_data_set( ).
90-
client->nav_app_call( z2ui5_cl_popup_js_loader=>factory( get_custom_js( ) ) ).
90+
client->nav_app_call( z2ui5_cl_pop_js_loader=>factory( get_custom_js( ) ) ).
9191
RETURN.
9292
ELSEIF check_initialized = abap_false.
9393
check_initialized = abap_true.

‎src/z2ui5_cl_demo_app_102.clas.abap‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ CLASS z2ui5_cl_demo_app_102 IMPLEMENTATION.
3737

3838
IF mv_check_init = abap_false.
3939
mv_check_init = abap_true.
40-
client->nav_app_call( z2ui5_cl_popup_js_loader=>factory( z2ui5_cl_cc_bwipjs=>get_js( ) ) ).
40+
client->nav_app_call( z2ui5_cl_pop_js_loader=>factory( z2ui5_cl_cc_bwipjs=>get_js( ) ) ).
4141
RETURN.
4242
ENDIF.
4343

‎src/z2ui5_cl_demo_app_107.clas.abap‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ CLASS Z2UI5_CL_DEMO_APP_107 IMPLEMENTATION.
7272

7373
IF check_load_cc = abap_false.
7474
check_load_cc = abap_true.
75-
client->nav_app_call( z2ui5_cl_popup_js_loader=>factory( get_custom_js( ) ) ).
75+
client->nav_app_call( z2ui5_cl_pop_js_loader=>factory( get_custom_js( ) ) ).
7676
RETURN.
7777

7878
ELSEIF check_initialized = abap_false.

‎src/z2ui5_cl_demo_app_111.clas.abap‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ CLASS z2ui5_cl_demo_app_111 IMPLEMENTATION.
5555
IF check_initialized = abap_false.
5656
check_initialized = abap_true.
5757
z2ui5_set_data( ).
58-
client->nav_app_call( z2ui5_cl_popup_js_loader=>factory( get_custom_js( ) ) ).
58+
client->nav_app_call( z2ui5_cl_pop_js_loader=>factory( get_custom_js( ) ) ).
5959
RETURN.
6060
ENDIF.
6161

‎src/z2ui5_cl_demo_app_126.clas.abap‎

Lines changed: 74 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -35,69 +35,51 @@ CLASS z2ui5_cl_demo_app_126 DEFINITION
3535

3636
ENDCLASS.
3737

38-
CLASS z2ui5_cl_demo_app_126 IMPLEMENTATION.
3938

40-
METHOD on_event.
41-
CASE client->get( )-event.
4239

43-
WHEN 'BACK'.
40+
CLASS Z2UI5_CL_DEMO_APP_126 IMPLEMENTATION.
4441

45-
client->nav_app_leave( client->get_app( client->get( )-s_draft-id_prev_app_stack ) ).
4642

47-
ENDCASE.
48-
ENDMETHOD.
49-
50-
METHOD on_init.
51-
get_Data( ).
52-
Render_main( ).
53-
ENDMETHOD.
54-
55-
METHOD render_main.
56-
IF mo_parent_view IS INITIAL.
43+
METHOD get_comp.
44+
TRY.
5745

58-
DATA(page) = z2ui5_cl_xml_view=>factory( ).
46+
DATA index TYPE int4.
5947

60-
ELSE.
48+
TRY.
6149

62-
page = mo_parent_view->get( `Page` ).
50+
cl_abap_typedescr=>describe_by_name( EXPORTING p_name = 'Z2UI5_T_UTIL_01'
51+
RECEIVING p_descr_ref = DATA(typedesc)
52+
EXCEPTIONS type_not_found = 1
53+
OTHERS = 2 ).
6354

64-
ENDIF.
55+
DATA(structdesc) = CAST cl_abap_structdescr( typedesc ).
6556

66-
DATA(layout) = page->vertical_layout( class = `sapUiContentPadding`
67-
width = `100%` ).
68-
layout->label( 'ProgressIndicator'
69-
)->progress_indicator( percentvalue = mv_perc
70-
displayvalue = '0,44GB of 32GB used'
71-
showvalue = abap_true
72-
state = 'Success' ).
57+
DATA(comp) = structdesc->get_components( ).
7358

74-
IF mo_parent_view IS INITIAL.
59+
LOOP AT comp INTO DATA(com).
7560

76-
client->view_display( page->get_root( )->xml_get( ) ).
61+
IF com-as_include = abap_false.
7762

78-
ELSE.
63+
APPEND com TO result.
7964

80-
mv_view_display = abap_true.
65+
ENDIF.
8166

82-
ENDIF.
83-
ENDMETHOD.
67+
ENDLOOP.
8468

85-
METHOD z2ui5_if_app~main.
86-
me->client = client.
69+
CATCH cx_root INTO DATA(root). " TODO: variable is assigned but never used (ABAP cleaner)
8770

88-
IF check_initialized = abap_false.
89-
check_initialized = abap_true.
71+
ENDTRY.
9072

91-
on_init( ).
73+
DATA(component) = VALUE cl_abap_structdescr=>component_table(
74+
( name = 'ROW_ID'
75+
type = CAST #( cl_abap_datadescr=>describe_by_data( index ) ) ) ).
9276

93-
ENDIF.
77+
APPEND LINES OF component TO result.
9478

95-
on_event( ).
79+
CATCH cx_root.
80+
ENDTRY.
9681
ENDMETHOD.
9782

98-
METHOD set_app_data.
99-
mv_perc = data.
100-
ENDMETHOD.
10183

10284
METHOD get_data.
10385
FIELD-SYMBOLS <table> TYPE STANDARD TABLE.
@@ -119,7 +101,7 @@ CLASS z2ui5_cl_demo_app_126 IMPLEMENTATION.
119101

120102
ASSIGN mt_table->* TO <table>.
121103

122-
SELECT * FROM Z2UI5_T_UTIL_01
104+
SELECT * FROM Z2UI5_T_01
123105
INTO CORRESPONDING FIELDS OF TABLE @<table>
124106
UP TO '100' ROWS.
125107

@@ -132,44 +114,70 @@ CLASS z2ui5_cl_demo_app_126 IMPLEMENTATION.
132114
<table_tmp> = <table>.
133115
ENDMETHOD.
134116

135-
METHOD get_comp.
136-
TRY.
137117

138-
DATA index TYPE int4.
118+
METHOD on_event.
119+
CASE client->get( )-event.
139120

140-
TRY.
121+
WHEN 'BACK'.
141122

142-
cl_abap_typedescr=>describe_by_name( EXPORTING p_name = 'Z2UI5_T_UTIL_01'
143-
RECEIVING p_descr_ref = DATA(typedesc)
144-
EXCEPTIONS type_not_found = 1
145-
OTHERS = 2 ).
123+
client->nav_app_leave( client->get_app( client->get( )-s_draft-id_prev_app_stack ) ).
146124

147-
DATA(structdesc) = CAST cl_abap_structdescr( typedesc ).
125+
ENDCASE.
126+
ENDMETHOD.
148127

149-
DATA(comp) = structdesc->get_components( ).
150128

151-
LOOP AT comp INTO DATA(com).
129+
METHOD on_init.
130+
get_Data( ).
131+
Render_main( ).
132+
ENDMETHOD.
152133

153-
IF com-as_include = abap_false.
154134

155-
APPEND com TO result.
135+
METHOD render_main.
136+
IF mo_parent_view IS INITIAL.
156137

157-
ENDIF.
138+
DATA(page) = z2ui5_cl_xml_view=>factory( ).
158139

159-
ENDLOOP.
140+
ELSE.
160141

161-
CATCH cx_root INTO DATA(root). " TODO: variable is assigned but never used (ABAP cleaner)
142+
page = mo_parent_view->get( `Page` ).
162143

163-
ENDTRY.
144+
ENDIF.
164145

165-
DATA(component) = VALUE cl_abap_structdescr=>component_table(
166-
( name = 'ROW_ID'
167-
type = CAST #( cl_abap_datadescr=>describe_by_data( index ) ) ) ).
146+
DATA(layout) = page->vertical_layout( class = `sapUiContentPadding`
147+
width = `100%` ).
148+
layout->label( 'ProgressIndicator'
149+
)->progress_indicator( percentvalue = mv_perc
150+
displayvalue = '0,44GB of 32GB used'
151+
showvalue = abap_true
152+
state = 'Success' ).
168153

169-
APPEND LINES OF component TO result.
154+
IF mo_parent_view IS INITIAL.
170155

171-
CATCH cx_root.
172-
ENDTRY.
156+
client->view_display( page->get_root( )->xml_get( ) ).
157+
158+
ELSE.
159+
160+
mv_view_display = abap_true.
161+
162+
ENDIF.
163+
ENDMETHOD.
164+
165+
166+
METHOD set_app_data.
167+
mv_perc = data.
173168
ENDMETHOD.
174169

170+
171+
METHOD z2ui5_if_app~main.
172+
me->client = client.
173+
174+
IF check_initialized = abap_false.
175+
check_initialized = abap_true.
176+
177+
on_init( ).
178+
179+
ENDIF.
180+
181+
on_event( ).
182+
ENDMETHOD.
175183
ENDCLASS.

0 commit comments

Comments
 (0)