Propagate the read status to the getEvent calls #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
eringerli
added a commit
to eringerli/Adafruit_LSM6DS
that referenced
this pull request
May 1, 2022
|
This looks like a useful and valid change to me - can we get this approved and merged, please? (Mentioning @tyeth, the last submitter to this repo, in the hopes that's someone who can move this along) |
Member
|
Just clearing emails and got to this 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this pull request is to implement the propagation of the read status through the getEvent calls, as is discussed in #26 . This allows users to check if the value provided by a getEvents is valid or is invalid, and to avoid feeding corrupted data further the pipes.
Test: this has been tested on a Sparkfun Artemis MCU based board against the Adafruit ISM330DHCX + LIS3MDL FeatherWing - High Precision 9-DoF IMU, PRODUCT ID: 4569. All compiling, no issues. I do not have more breakouts to test this myself.
If you have any comments please let me know :) .