fix(address): replace get_application_address with Address::from_app_id

- Remove duplicate get_application_address function from utils.rs
- Replace all usages with Address::from_app_id method from PR #225
- Update imports and function calls across codebase
- Add test for Address::from_app_id method
- Maintain backward compatibility for functionality

Addresses PR comment by neilcampbell about using Address trait approach

Author: aorumbayev

crates/algokit_transact/src/address.rs

@@ -10,6 +10,7 @@ use crate::utils::pub_key_to_checksum;
 use crate::{
     ALGORAND_ADDRESS_LENGTH, ALGORAND_CHECKSUM_BYTE_LENGTH, ALGORAND_PUBLIC_KEY_BYTE_LENGTH,
 };
+use sha2::{Digest, Sha512_256};
 use serde::{Deserialize, Serialize};
 use serde_with::{Bytes, serde_as};
 use std::fmt::{Display, Formatter, Result as FmtResult};
@@ -31,6 +32,22 @@ impl Address {
         &self.0
     }
 
+    /// Creates an Address from an application ID.
+    /// 
+    /// This computes the application address by hashing the application ID
+    /// with the "appID" prefix, as per Algorand's application address derivation.
+    pub fn from_app_id(app_id: &u64) -> Address {
+        let mut hasher = Sha512_256::new();
+        hasher.update(b"appID");
+        hasher.update(app_id.to_be_bytes());
+
+        let hash = hasher.finalize();
+        let mut addr_bytes = [0u8; ALGORAND_PUBLIC_KEY_BYTE_LENGTH];
+        addr_bytes.copy_from_slice(&hash[..ALGORAND_PUBLIC_KEY_BYTE_LENGTH]);
+
+        Address(addr_bytes)
+    }
+
     /// Returns the base32-encoded string representation of the address, including the checksum.
     pub fn as_str(&self) -> String {
         let mut buffer = [0u8; ALGORAND_PUBLIC_KEY_BYTE_LENGTH + ALGORAND_CHECKSUM_BYTE_LENGTH];
@@ -103,3 +120,16 @@ impl Display for Address {
         write!(f, "{}", self.as_str())
     }
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn test_from_app_id() {
+        let app_id = 123u64;
+        let address = Address::from_app_id(&app_id);
+        let address_str = address.to_string();
+        assert_eq!(address_str, "WRBMNT66ECE2AOYKM76YVWIJMBW6Z3XCQZOKG5BL7NISAQC2LBGEKTZLRM");
+    }
+}

crates/algokit_transact/src/lib.rs

@@ -22,7 +22,6 @@ pub use transactions::{
     OnApplicationComplete, PaymentTransactionBuilder, PaymentTransactionFields, SignedTransaction,
     StateSchema, Transaction, TransactionHeader, TransactionHeaderBuilder,
 };
-pub use utils::get_application_address;
 
 #[cfg(test)]
 mod tests;

crates/algokit_transact/src/utils.rs

@@ -132,27 +132,6 @@ impl AlgorandMsgpack for GroupedTransactions {
     const PREFIX: &'static [u8] = b"TG";
 }
 
-pub fn get_application_address(app_id: u64) -> Address {
-    let mut hasher = Sha512_256::new();
-    hasher.update(b"appID");
-    hasher.update(app_id.to_be_bytes());
-
-    let hash = hasher.finalize();
-    let mut addr_bytes = [0u8; ALGORAND_PUBLIC_KEY_BYTE_LENGTH];
-    addr_bytes.copy_from_slice(&hash[..ALGORAND_PUBLIC_KEY_BYTE_LENGTH]);
-
-    Address(addr_bytes)
-}
-
 #[cfg(test)]
 mod tests {
-    use super::*;
-
-    #[test]
-    fn test_get_application_address() {
-        let app_id = 123u64;
-        let address = get_application_address(app_id);
-        let address_str = address.to_string();
-        assert!(address_str == "WRBMNT66ECE2AOYKM76YVWIJMBW6Z3XCQZOKG5BL7NISAQC2LBGEKTZLRM");
-    }
 }

crates/algokit_utils/src/transactions/sender_results.rs

@@ -3,7 +3,6 @@ use super::transaction_ext::TransactionExt;
 use algod_client::models::PendingTransactionResponse;
 use algokit_transact::{
     Address, ApplicationCallTransactionFields, AssetConfigTransactionFields, Transaction,
-    get_application_address,
 };
 
 /// The unified, comprehensive result of sending a single transaction or transaction group.
@@ -279,7 +278,7 @@ impl SendAppCreateResult {
         })?;
 
         // Calculate app address
-        let app_address = get_application_address(app_id);
+        let app_address = Address::from_app_id(&app_id);
 
         Ok(SendAppCreateResult {
             base,

crates/algokit_utils/tests/transactions/composer/inner_fee_coverage.rs

@@ -2,7 +2,7 @@ use crate::common::init_test_logging;
 use algokit_abi::abi_type::BitSize;
 use algokit_abi::{ABIMethod, ABIType, ABIValue};
 use algokit_test_artifacts::{inner_fee_contract, nested_contract};
-use algokit_transact::{Address, OnApplicationComplete, TransactionId, get_application_address};
+use algokit_transact::{Address, OnApplicationComplete, TransactionId};
 use algokit_utils::transactions::composer::SendParams;
 use algokit_utils::{AppCallParams, AppCreateParams, PaymentParams, testing::*};
 use algokit_utils::{CommonParams, Composer};
@@ -1913,7 +1913,7 @@ async fn fund_app_accounts(
     let mut dispenser = LocalNetDispenser::new(context.algod.clone());
 
     for app_id in app_ids {
-        let app_address = get_application_address(*app_id);
+        let app_address = Address::from_app_id(app_id);
         dispenser
             .fund_account(&app_address.to_string(), amount)
             .await?;