feat: app method call support in ffi composer #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-p
requested review from
PatrickDinh and
Copilot
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds FFI support for application (app) create / call / method-call transactions and ABI type/value encoding/decoding, plus corresponding Python tests.
- Introduces new ABI FFI layer (types and values) and app call transaction parameter structs.
- Extends Composer with add_app_create, add_app_call, and add_app_call_method_call methods.
- Adds tests for ABI encoding/decoding and end-to-end app create / call / method call flows.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/python/algokit_utils/tests/test_utils.py | Adds ABI encoding tests and app create/call/method call test cases. |
| crates/algokit_utils_ffi/src/transactions/mod.rs | Registers new app_call module. |
| crates/algokit_utils_ffi/src/transactions/composer.rs | Adds composer methods for app create, call, and method call. |
| crates/algokit_utils_ffi/src/transactions/app_call.rs | Implements FFI structs/enums and conversions for app call, create, and method call (including ABI method definitions). |
| crates/algokit_utils_ffi/src/lib.rs | Exposes new abi module. |
| crates/algokit_utils_ffi/src/abi/mod.rs | Adds ABI module exports. |
| crates/algokit_utils_ffi/src/abi/abi_value.rs | Adds ABIValue FFI object and accessors. |
| crates/algokit_utils_ffi/src/abi/abi_type.rs | Adds ABIType, struct field abstractions, and encoding/decoding helpers. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lempira
reviewed
Oct 1, 2025
| @@ -0,0 +1,624 @@ | |||
| use crate::abi::{abi_type::ABIType, abi_value::ABIValue}; | |||
Collaborator
Author
There was a problem hiding this comment.
Since we don't have algod client we don't have the full response modeled. We can add ABI return now though if you want
PatrickDinh
reviewed
Oct 2, 2025
joe-p
force-pushed
the
feat/ffi_composer_appl
branch
from
e4442b0 to
8012658
Compare
lempira
approved these changes
Oct 2, 2025
Contributor
|
🎉 This PR is included in version 1.0.0-alpha.72 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for app method calls to the composer