From 605fa6c0d6870ac42669f9e5160f3d3e2f873eae Mon Sep 17 00:00:00 2001 From: Alexey Stukalov Date: Sun, 14 Apr 2024 20:21:42 -0700 Subject: [PATCH 1/3] fix typo --- src/loss/WLS/WLS.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/loss/WLS/WLS.jl b/src/loss/WLS/WLS.jl index 2fd053f2d..4133ddbf7 100644 --- a/src/loss/WLS/WLS.jl +++ b/src/loss/WLS/WLS.jl @@ -22,7 +22,7 @@ Weighted least squares estimation. - `approximate_hessian::Bool`: should the hessian be swapped for an approximation - `wls_weight_matrix`: the weight matrix for weighted least squares. Defaults to GLS estimation (``0.5*(D^T*kron(S,S)*D)`` where D is the duplication matrix - and S is the inverse ob the observed covariance matrix) + and S is the inverse of the observed covariance matrix) - `wls_weight_matrix_mean`: the weight matrix for the mean part of weighted least squares. Defaults to GLS estimation (the inverse of the observed covariance matrix) From 2ee4ef7fc9d285d8ddb1222c4b93a313b6ec5793 Mon Sep 17 00:00:00 2001 From: Alexey Stukalov Date: Sun, 14 Apr 2024 20:28:31 -0700 Subject: [PATCH 2/3] use v2 --- .github/workflows/FormatCheck.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/FormatCheck.yml b/.github/workflows/FormatCheck.yml index 34309b612..6a3ec0fa1 100644 --- a/.github/workflows/FormatCheck.yml +++ b/.github/workflows/FormatCheck.yml @@ -7,4 +7,4 @@ jobs: code-style: runs-on: ubuntu-latest steps: - - uses: julia-actions/julia-format@master + - uses: julia-actions/julia-format@v2 From 26f1b2643e785d4489d4091060fd02a58ec32a03 Mon Sep 17 00:00:00 2001 From: Alexey Stukalov Date: Sun, 14 Apr 2024 20:34:30 -0700 Subject: [PATCH 3/3] test 2 --- src/loss/WLS/WLS.jl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/loss/WLS/WLS.jl b/src/loss/WLS/WLS.jl index 4133ddbf7..f7728d8bb 100644 --- a/src/loss/WLS/WLS.jl +++ b/src/loss/WLS/WLS.jl @@ -171,8 +171,8 @@ function objective_gradient!(semwls::SemWLS, par, model::AbstractSemSingle, has_ gradient = -2*(σ₋'*V*∇σ + μ₋'*V_μ*∇μ)' return objective, gradient else - objective = dot(σ₋, V, σ₋) - gradient = -2*(σ₋'*V*∇σ)' + objective = dot(σ₋, V, σ₋) + gradient = -2*(σ₋'*V* ∇σ)' return objective, gradient end end