Skip to content

Conversation

@bgiori
Copy link
Collaborator

@bgiori bgiori commented Nov 17, 2023

Summary

Implement Evaluation V2

  • New evaluation binary with updated interface.
  • New /v2/vardata and /v2/flags apis for remote and local evaluation
  • Additional info sent in Assignment event.
  • New evaluate_v2 and fetch_v2 methods for consuming v2 results.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@bgiori bgiori requested a review from tyiuhc November 17, 2023 01:31
@tyiuhc
Copy link
Collaborator

tyiuhc commented Nov 17, 2023

nit: there seems to be an error in the remote fetch_async_with_retry test case - TypeError: callback_for_async() takes 3 positional arguments but 4 were given

@bgiori bgiori requested a review from tyiuhc November 22, 2023 21:32
@bgiori bgiori merged commit 8a57489 into main Dec 1, 2023
@bgiori bgiori deleted the evaluation-v2 branch December 1, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants