Skip to content

Conversation

@tyiuhc
Copy link
Collaborator

@tyiuhc tyiuhc commented Jun 14, 2024

Summary

Support cohort targeting for local evaluation

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@tyiuhc tyiuhc marked this pull request as ready for review June 14, 2024 22:29
@tyiuhc tyiuhc requested a review from bgiori June 14, 2024 22:29
Copy link
Collaborator

@bgiori bgiori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice. Couple of simplifications suggested.

Lets talk through config's api key, deployment key, etc. tomorrow.

@tyiuhc tyiuhc requested a review from bgiori June 26, 2024 21:08
…ning if evaluating flag without required cohorts
…delay, use enum for serverzone, update tests accordingly
@tyiuhc tyiuhc merged commit d8c62c4 into main Aug 27, 2024
@tyiuhc tyiuhc deleted the local-cohort branch August 27, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants