Improve logging by including full stack trace, and add release note

Author: icbaker

RELEASENOTES.md

@@ -97,6 +97,9 @@
     *   Fix bug where `MediaMetadata` was only populated from Vorbis comments
         with upper-case keys
         ([#876](https://github.com/androidx/media/issues/876)).
+    *   Catch `OutOfMemoryError` when parsing very large ID3 frames, meaning
+        playback can continue without the tag info instead of playback failing
+        completely.
 *   DRM:
     *   Extend workaround for spurious ClearKey `https://default.url` license
         URL to API 33+ (previously the workaround only applied on API 33

libraries/extractor/src/main/java/androidx/media3/extractor/metadata/id3/Id3Decoder.java

@@ -64,7 +64,6 @@ public interface FramePredicate {
 
   /** The first three bytes of a well formed ID3 tag header. */
   public static final int ID3_TAG = 0x00494433;
-
   /** Length of an ID3 tag header. */
   public static final int ID3_HEADER_LENGTH = 10;
 
@@ -372,8 +371,8 @@ private static Id3Frame decodeFrame(
       frameSize = removeUnsynchronization(id3Data, frameSize);
     }
 
-    String error = "";
     Id3Frame frame = null;
+    Throwable error = null;
     try {
       if (frameId0 == 'T'
           && frameId1 == 'X'
@@ -431,10 +430,8 @@ private static Id3Frame decodeFrame(
         String id = getFrameId(majorVersion, frameId0, frameId1, frameId2, frameId3);
         frame = decodeBinaryFrame(id3Data, frameSize, id);
       }
-    } catch (Exception e) {
-      error = ",error=" + e.getMessage();
-    } catch (OutOfMemoryError e) {
-      error = ",error=" + e.getMessage();
+    } catch (OutOfMemoryError | Exception e) {
+      error = e;
     } finally {
       id3Data.setPosition(nextFramePosition);
     }
@@ -444,8 +441,8 @@ private static Id3Frame decodeFrame(
           "Failed to decode frame: id="
               + getFrameId(majorVersion, frameId0, frameId1, frameId2, frameId3)
               + ", frameSize="
-              + frameSize
-              + error);
+              + frameSize,
+          error);
     }
     return frame;
   }