Bug fix: ensure platform session is in a consistent state before updating media3 controllers

Author: nift4

libraries/session/src/main/java/androidx/media3/session/MediaLibrarySessionImpl.java

@@ -27,7 +27,6 @@
 import android.app.PendingIntent;
 import android.content.Context;
 import android.os.Bundle;
-import android.os.RemoteException;
 import androidx.annotation.Nullable;
 import androidx.media3.common.MediaItem;
 import androidx.media3.common.MediaMetadata;
@@ -359,19 +358,6 @@ protected MediaSessionServiceLegacyStub createLegacyBrowserService(
     return stub;
   }
 
-  @Override
-  protected void dispatchRemoteControllerTaskWithoutReturn(RemoteControllerTask task) {
-    super.dispatchRemoteControllerTaskWithoutReturn(task);
-    @Nullable MediaLibraryServiceLegacyStub legacyStub = getLegacyBrowserService();
-    if (legacyStub != null) {
-      try {
-        task.run(legacyStub.getBrowserLegacyCbForBroadcast(), /* seq= */ 0);
-      } catch (RemoteException e) {
-        Log.e(TAG, "Exception in using media1 API", e);
-      }
-    }
-  }
-
   private void maybeUpdateLegacyErrorState(ControllerInfo browser, LibraryResult<?> result) {
     if (libraryErrorReplicationMode == MediaLibrarySession.LIBRARY_ERROR_REPLICATION_MODE_NONE
         || browser.getControllerVersion() != ControllerInfo.LEGACY_CONTROLLER_VERSION) {

libraries/session/src/main/java/androidx/media3/session/MediaSession.java

@@ -51,8 +51,6 @@
 import androidx.media3.common.Player.RepeatMode;
 import androidx.media3.common.Rating;
 import androidx.media3.common.Timeline;
-import androidx.media3.common.TrackSelectionParameters;
-import androidx.media3.common.Tracks;
 import androidx.media3.common.VideoSize;
 import androidx.media3.common.util.BitmapLoader;
 import androidx.media3.common.util.UnstableApi;
@@ -2319,11 +2317,6 @@ default void onIsPlayingChanged(int seq, boolean isPlaying) throws RemoteExcepti
 
     default void onIsLoadingChanged(int seq, boolean isLoading) throws RemoteException {}
 
-    default void onTracksChanged(int seq, Tracks tracks) throws RemoteException {}
-
-    default void onTrackSelectionParametersChanged(int seq, TrackSelectionParameters parameters)
-        throws RemoteException {}
-
     default void onPlaybackParametersChanged(int seq, PlaybackParameters playbackParameters)
         throws RemoteException {}