Skip to content

Commit e4e59cd

Browse files
toniheishahdDaghash
authored andcommitted
Switch default of async crypto mode to disabled
There are reproducible issues with codec timeouts when using this API, so we disable it entirely until we know more about potential fixes and where they are available. Issue: #1641 PiperOrigin-RevId: 707025950 (cherry picked from commit 71f82df)
1 parent 508a425 commit e4e59cd

File tree

3 files changed

+19
-3
lines changed

3 files changed

+19
-3
lines changed

RELEASENOTES.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,22 @@
2020
* Reduce default values for `bufferForPlaybackMs` and
2121
`bufferForPlaybackAfterRebufferMs` in `DefaultLoadControl` to 1000 and
2222
2000 ms respectively.
23+
* Add `MediaExtractorCompat`, a new class that provides equivalent
24+
functionality to platform `MediaExtractor`.
25+
* Move `BasePreloadManager.Listener` to a top level
26+
`PreloadManagerListener`.
27+
* `RenderersFactory.createSecondaryRenderer` can be implemented to provide
28+
secondary renderers for pre-warming. Pre-warming enables quicker media
29+
item transitions during playback.
30+
* Enable sending `CmcdData` for manifest requests in adaptive streaming
31+
formats DASH, HLS, and SmoothStreaming
32+
([#1951](https://github.com/androidx/media/issues/1951)).
33+
* Provide `MediaCodecInfo` of the codec that will be initialized in
34+
`MediaCodecRenderer.onReadyToInitializeCodec`
35+
([#1963](https://github.com/androidx/media/pull/1963)).
36+
* Disable use of asynchronous decryption in MediaCodec to avoid reported
37+
codec timeout issues with this platform API
38+
([#1641](https://github.com/androidx/media/issues/1641)).
2339
* Transformer:
2440
* Update parameters of `VideoFrameProcessor.registerInputStream` and
2541
`VideoFrameProcessor.Listener.onInputStreamRegistered` to use `Format`.

libraries/exoplayer/src/main/java/androidx/media3/exoplayer/mediacodec/AsynchronousMediaCodecAdapter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ public Factory(@C.TrackType int trackType) {
8080
Supplier<HandlerThread> queueingThreadSupplier) {
8181
this.callbackThreadSupplier = callbackThreadSupplier;
8282
this.queueingThreadSupplier = queueingThreadSupplier;
83-
enableSynchronousBufferQueueingWithAsyncCryptoFlag = true;
83+
enableSynchronousBufferQueueingWithAsyncCryptoFlag = false;
8484
}
8585

8686
/**

libraries/exoplayer/src/main/java/androidx/media3/exoplayer/mediacodec/DefaultMediaCodecAdapterFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public final class DefaultMediaCodecAdapterFactory implements MediaCodecAdapter.
6767
@Deprecated
6868
public DefaultMediaCodecAdapterFactory() {
6969
asynchronousMode = MODE_DEFAULT;
70-
asyncCryptoFlagEnabled = true;
70+
asyncCryptoFlagEnabled = false;
7171
context = null;
7272
}
7373

@@ -79,7 +79,7 @@ public DefaultMediaCodecAdapterFactory() {
7979
public DefaultMediaCodecAdapterFactory(Context context) {
8080
this.context = context;
8181
asynchronousMode = MODE_DEFAULT;
82-
asyncCryptoFlagEnabled = true;
82+
asyncCryptoFlagEnabled = false;
8383
}
8484

8585
/**

0 commit comments

Comments
 (0)