Skip to content

Commit e5a30d4

Browse files
committed
Updated non-Square thumbnail unit test to contain non-Square thumbnails
1 parent ddbb0ef commit e5a30d4

File tree

1 file changed

+24
-16
lines changed

1 file changed

+24
-16
lines changed

libraries/exoplayer/src/test/java/androidx/media3/exoplayer/image/ImageRendererTest.java

Lines changed: 24 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import static com.google.common.truth.Truth.assertThat;
2222

2323
import android.graphics.Bitmap;
24+
import android.graphics.Color;
2425
import android.util.Pair;
2526
import androidx.media3.common.C;
2627
import androidx.media3.common.Format;
@@ -75,8 +76,8 @@ public class ImageRendererTest {
7576
private static final Format JPEG_FORMAT_WITH_SIX_TILES =
7677
new Format.Builder()
7778
.setSampleMimeType(MimeTypes.IMAGE_JPEG)
78-
.setTileCountVertical(3)
79-
.setTileCountHorizontal(2)
79+
.setTileCountVertical(2)
80+
.setTileCountHorizontal(3)
8081
.build();
8182

8283
private final List<Pair<Long, Bitmap>> renderedBitmaps = new ArrayList<>();
@@ -721,8 +722,13 @@ public void render_tiledImageStartPositionRightBeforeEOSAndWithinThreshold_rende
721722
public void render_tiledImageNonSquare_rendersAllImagesToOutput() throws Exception {
722723
ImageDecoder.Factory fakeDecoderFactory =
723724
new BitmapFactoryImageDecoder.Factory(
724-
(data, length) ->
725-
Bitmap.createBitmap(/* width= */ 2, /* height= */ 3, Bitmap.Config.ARGB_8888));
725+
(data, length) -> {
726+
Bitmap bm =
727+
Bitmap.createBitmap(/* width= */ 9, /* height= */ 4, Bitmap.Config.ARGB_8888);
728+
bm.setPixel(1, 2, Color.rgb(100, 0, 0));
729+
bm.setPixel(4, 3, Color.rgb(0, 100, 0));
730+
return bm;
731+
});
726732
ImageOutput queuingImageOutput =
727733
new ImageOutput() {
728734
@Override
@@ -777,23 +783,25 @@ public void onDisabled() {
777783

778784
assertThat(renderedBitmaps).hasSize(6);
779785
assertThat(renderedBitmaps.get(0).first).isEqualTo(0L);
780-
assertThat(renderedBitmaps.get(0).second.getHeight()).isEqualTo(1);
781-
assertThat(renderedBitmaps.get(0).second.getWidth()).isEqualTo(1);
786+
assertThat(renderedBitmaps.get(0).second.getHeight()).isEqualTo(2);
787+
assertThat(renderedBitmaps.get(0).second.getWidth()).isEqualTo(3);
782788
assertThat(renderedBitmaps.get(1).first).isEqualTo(100_000L);
783-
assertThat(renderedBitmaps.get(1).second.getHeight()).isEqualTo(1);
784-
assertThat(renderedBitmaps.get(1).second.getWidth()).isEqualTo(1);
789+
assertThat(renderedBitmaps.get(1).second.getHeight()).isEqualTo(2);
790+
assertThat(renderedBitmaps.get(1).second.getWidth()).isEqualTo(3);
785791
assertThat(renderedBitmaps.get(2).first).isEqualTo(200_000L);
786-
assertThat(renderedBitmaps.get(2).second.getHeight()).isEqualTo(1);
787-
assertThat(renderedBitmaps.get(2).second.getWidth()).isEqualTo(1);
792+
assertThat(renderedBitmaps.get(2).second.getHeight()).isEqualTo(2);
793+
assertThat(renderedBitmaps.get(2).second.getWidth()).isEqualTo(3);
788794
assertThat(renderedBitmaps.get(3).first).isEqualTo(300_000L);
789-
assertThat(renderedBitmaps.get(3).second.getHeight()).isEqualTo(1);
790-
assertThat(renderedBitmaps.get(3).second.getWidth()).isEqualTo(1);
795+
assertThat(renderedBitmaps.get(3).second.getHeight()).isEqualTo(2);
796+
assertThat(renderedBitmaps.get(3).second.getWidth()).isEqualTo(3);
797+
assertThat(renderedBitmaps.get(3).second.getPixel(1, 0)).isEqualTo(Color.rgb(100, 0, 0));
791798
assertThat(renderedBitmaps.get(4).first).isEqualTo(400_000L);
792-
assertThat(renderedBitmaps.get(4).second.getHeight()).isEqualTo(1);
793-
assertThat(renderedBitmaps.get(4).second.getWidth()).isEqualTo(1);
799+
assertThat(renderedBitmaps.get(4).second.getHeight()).isEqualTo(2);
800+
assertThat(renderedBitmaps.get(4).second.getWidth()).isEqualTo(3);
801+
assertThat(renderedBitmaps.get(4).second.getPixel(1,1)).isEqualTo(Color.rgb(0, 100, 0));
794802
assertThat(renderedBitmaps.get(5).first).isEqualTo(500_000L);
795-
assertThat(renderedBitmaps.get(5).second.getHeight()).isEqualTo(1);
796-
assertThat(renderedBitmaps.get(5).second.getWidth()).isEqualTo(1);
803+
assertThat(renderedBitmaps.get(5).second.getHeight()).isEqualTo(2);
804+
assertThat(renderedBitmaps.get(5).second.getWidth()).isEqualTo(3);
797805
}
798806

799807
private static FakeSampleStream.FakeSampleStreamItem emptySample(

0 commit comments

Comments
 (0)