fix(@angular/cli): correctly set default array values

Previously, default array values were being incorrectly treated as strings.

(cherry picked from commit 47d77a3)

Author: alan-agius4

packages/angular/cli/src/command-builder/schematics-command-module.ts

@@ -204,13 +204,20 @@ export abstract class SchematicsCommandModule
                     ? {
                         name: item,
                         value: item,
-                        checked: item === definition.default,
+                        checked:
+                          definition.multiselect && Array.isArray(definition.default)
+                            ? definition.default?.includes(item)
+                            : item === definition.default,
                       }
                     : {
                         ...item,
                         name: item.label,
                         value: item.value,
-                        checked: item.value === definition.default,
+                        checked:
+                          definition.multiselect && Array.isArray(definition.default)
+                            ? // eslint-disable-next-line @typescript-eslint/no-explicit-any
+                              definition.default?.includes(item.value as any)
+                            : item.value === definition.default,
                       },
                 ),
               });

packages/angular/cli/src/command-builder/utilities/json-schema.ts

@@ -197,15 +197,19 @@ export async function parseJsonSchemaToOptions(
       .filter((value) => isValidTypeForEnum(typeof value))
       .sort() as (string | true | number)[];
 
-    let defaultValue: string | number | boolean | undefined = undefined;
+    let defaultValue: string | number | boolean | unknown[] | undefined = undefined;
     if (current.default !== undefined) {
       switch (types[0]) {
         case 'string':
-        case 'array':
           if (typeof current.default == 'string') {
             defaultValue = current.default;
           }
           break;
+        case 'array':
+          if (Array.isArray(current.default)) {
+            defaultValue = current.default;
+          }
+          break;
         case 'number':
           if (typeof current.default == 'number') {
             defaultValue = current.default;

packages/angular/cli/src/command-builder/utilities/json-schema_spec.ts

@@ -37,7 +37,7 @@ describe('parseJsonSchemaToOptions', () => {
           },
           'arrayWithChoices': {
             'type': 'array',
-            'default': 'default-array',
+            'default': ['default-array'],
             'items': {
               'type': 'string',
               'enum': ['always', 'never', 'default-array'],
@@ -91,7 +91,7 @@ describe('parseJsonSchemaToOptions', () => {
       });
 
       it('should add default value to help', async () => {
-        expect(await localYargs.getHelp()).toContain('[default: "default-array"]');
+        expect(await localYargs.getHelp()).toContain('[default: ["default-array"]]');
       });
     });
 

packages/angular_devkit/build_angular/src/builders/browser/specs/unused-files-warning_spec.ts

@@ -238,7 +238,7 @@ describe('Browser Builder unused files warnings', () => {
               host.appendToFile('src/main.ts', '');
               break;
             case 2:
-              // The second should should have type.ts as unused but shouldn't warn.
+              // The second should have type.ts as unused but shouldn't warn.
               expect(logs.join().includes(warningMessageSuffix)).toBe(
                 false,
                 `Case ${buildNumber} failed.`,