reworked dialog closeAll & open events based on feedback

Author: thomaspink

src/demo-app/dialog/dialog-demo.ts

@@ -27,12 +27,12 @@ export class DialogDemo {
     // Possible useful example for the open and closeAll events.
     // Adding a class to the body if a dialog opens and
     // removing it after all open dialogs are closed
-    dialog.afterOpen().subscribe((ref: MdDialogRef<any>) => {
+    dialog.afterOpen.subscribe((ref: MdDialogRef<any>) => {
       if (!doc.body.classList.contains('no-scroll')) {
         doc.body.classList.add('no-scroll');
       }
     });
-    dialog.afterAllClosed().subscribe(_ => {
+    dialog.afterAllClosed.subscribe(() => {
       doc.body.classList.remove('no-scroll');
     });
   }

src/lib/dialog/dialog.spec.ts

@@ -137,7 +137,7 @@ describe('MdDialog', () => {
 
   it('should notify the observers if a dialog has been opened', () => {
     let ref: MdDialogRef<PizzaMsg>;
-    dialog.afterOpen().subscribe(r => {
+    dialog.afterOpen.subscribe(r => {
       ref = r;
     });
     expect(dialog.open(PizzaMsg, {
@@ -154,7 +154,7 @@ describe('MdDialog', () => {
     });
     let allClosed = false;
 
-    dialog.afterAllClosed().subscribe(_ => {
+    dialog.afterAllClosed.subscribe(() => {
       allClosed = true;
     });
 

src/lib/dialog/dialog.ts

@@ -25,10 +25,16 @@ export class MdDialog {
   private _openDialogs: MdDialogRef<any>[] = [];
 
   /** Subject for notifying the user that all open dialogs have finished closing. */
-  private _afterAllClosed: Subject<any> = new Subject();
+  private _afterAllClosed = new Subject<void>();
 
   /** Subject for notifying the user that a dialog has opened. */
-  private _afterOpen: Subject<any> = new Subject();
+  private _afterOpen = new Subject<MdDialogRef<any>>();
+
+  /** Gets an observable that is notified when a dialog has been opened. */
+  afterOpen = this._afterOpen.asObservable();
+
+  /** Gets an observable that is notified when all open dialog have finished closing. */
+  afterAllClosed = this._afterAllClosed.asObservable();
 
   constructor(private _overlay: Overlay, private _injector: Injector) { }
 
@@ -67,20 +73,6 @@ export class MdDialog {
     }
   }
 
-  /**
-   * Gets an observable that is notified when a dialog has been opened.
-   */
-  afterOpen(): Observable<any> {
-    return this._afterOpen.asObservable();
-  }
-
-  /**
-   * Gets an observable that is notified when all open dialog have finished closing.
-   */
-  afterAllClosed(): Observable<any> {
-    return this._afterAllClosed.asObservable();
-  }
-
   /**
    * Creates the overlay into which the dialog will be loaded.
    * @param dialogConfig The dialog configuration.