fix(bazel): conditionally add esbuild optimization plugins (#2243)

This update prevents the inclusion of esbuild optimization plugins when both linking and downleveling are disabled. It also removes //shared-scripts/angular-optimization:js_lib from the spec-bundle unless explicit linking is required. This change addresses a circular dependency issue previously observed with this rule in the Angular CLI, leading to the removal of a related patch. For more details, see:  https://github.com/angular/angular-cli/blob/3c9697a8c34a5e0f3470bde73f11f9f32107f42e/.yarn/patches/%40angular-build-tooling-https-06f4984cdf.patch

Author: alan-agius4

bazel/spec-bundling/esbuild.config-tmpl.mjs

@@ -6,14 +6,38 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {createEsbuildAngularOptimizePlugin} from '@angular/build-tooling/shared-scripts/angular-optimization/esbuild-plugin.mjs';
+const downlevelAsyncAwait = TMPL_DOWNLEVEL_ASYNC_AWAIT;
+const enableLinker = TMPL_RUN_LINKER;
+
+// List of esbuild plugins.
+const plugins = [];
+if (enableLinker || downlevelAsyncAwait) {
+  const {createEsbuildAngularOptimizePlugin} = await import(
+    '@angular/build-tooling/shared-scripts/angular-optimization/esbuild-plugin.mjs'
+  );
+
+  plugins.push(
+    await createEsbuildAngularOptimizePlugin({
+      optimize: undefined,
+      downlevelAsyncGeneratorsIfPresent: downlevelAsyncAwait,
+      enableLinker: enableLinker
+        ? {
+            ensureNoPartialDeclaration: true,
+            linkerOptions: {
+              // JIT mode is needed for tests overriding components/modules etc.
+              linkerJitMode: true,
+              unknownDeclarationVersionHandling: TMPL_LINKER_UNKNOWN_DECLARATION_HANDLING,
+            },
+          }
+        : undefined,
+    }),
+  );
+}
 
 // List of supported features as per ESBuild. See:
 // https://esbuild.github.io/api/#supported.
 const supported = {};
 
-const downlevelAsyncAwait = TMPL_DOWNLEVEL_ASYNC_AWAIT;
-
 // Async/Await can be downleveled so that ZoneJS can intercept. See:
 // https://github.com/angular/angular-cli/blob/afe9feaa45913/packages/angular_devkit/build_angular/src/builders/browser-esbuild/index.ts#L313-L318.
 if (downlevelAsyncAwait) {
@@ -35,20 +59,5 @@ export default {
   // https://esbuild.github.io/api/#keep-names.
   keepNames: true,
   supported,
-  plugins: [
-    await createEsbuildAngularOptimizePlugin({
-      optimize: undefined,
-      downlevelAsyncGeneratorsIfPresent: downlevelAsyncAwait,
-      enableLinker: TMPL_RUN_LINKER
-        ? {
-            ensureNoPartialDeclaration: true,
-            linkerOptions: {
-              // JIT mode is needed for tests overriding components/modules etc.
-              linkerJitMode: true,
-              unknownDeclarationVersionHandling: TMPL_LINKER_UNKNOWN_DECLARATION_HANDLING,
-            },
-          }
-        : undefined,
-    }),
-  ],
+  plugins,
 };

bazel/spec-bundling/spec-bundle.bzl

@@ -60,11 +60,15 @@ def spec_bundle(
         linker_unknown_declaration_handling = linker_unknown_declaration_handling,
     )
 
+    esbuild_config_deps = []
+    if run_angular_linker or downlevel_async_await:
+        esbuild_config_deps = ["//shared-scripts/angular-optimization:js_lib"]
+
     esbuild_config(
         name = "%s_config" % name,
         config_file = ":%s_config_file" % name,
         testonly = True,
-        deps = ["//shared-scripts/angular-optimization:js_lib"],
+        deps = esbuild_config_deps,
     )
 
     if is_browser_test and not workspace_name: