Skip to content

Conversation

@crisbeto
Copy link
Member

Currently md-select can only really be used together with @angular/forms which is overkill for simple usages where it only sets a value (for example, the only reason the paginator module brings in the FormsModule is the select). These changes introduce the value two-way binding that can be used to read/write the value without using ngModel or a formControl. This also aligns it with the input module.

Relates to #5717.

Currently `md-select` can only really be used together with `@angular/forms` which is overkill for simple usages where it only sets a value (for example, the only reason the paginator module brings in the `FormsModule` is the select). These changes introduce the `value` two-way binding that can be used to read/write the value without using `ngModel` or a `formControl`. This also aligns it with the input module.

Relates to angular#5717.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 19, 2017
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was thinking we should probably add a value-only demo to our demo page too, for future testing. Can you add that and apply label when ready?

@kara kara assigned crisbeto and unassigned kara Jul 21, 2017
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 22, 2017
@andrewseguin andrewseguin merged commit 9a90eaf into angular:master Jul 25, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants