feat(a11y): add autoCapture option to cdkTrapFocus #7641
Conversation
googlebot
added
the
cla: yes
| * initialization and return focus to the previous activeElement upon destruction. | ||
| */ | ||
| @Input('cdkTrapFocusAutoCapture') | ||
| get autoCapture(): boolean { return this._autoCapture; } |
There was a problem hiding this comment.
Since this won't react to value changes, maybe it should be a plain @Input without the coercion or it should take the value via an @Attribute?
There was a problem hiding this comment.
I made it an input since people may want to build a higher-level component on top of it and forward from their own API for the equivalent behavior
There was a problem hiding this comment.
Makes sense, although I do feel like we're starting to add the coercion to everything.
There was a problem hiding this comment.
I'm going to push for Angular to add @BooleanInput (and @NumberInput) to help with this.
| * initialization and return focus to the previous activeElement upon destruction. | ||
| */ | ||
| @Input('cdkTrapFocusAutoCapture') | ||
| get autoCapture(): boolean { return this._autoCapture; } |
There was a problem hiding this comment.
Makes sense, although I do feel like we're starting to add the coercion to everything.
crisbeto
added
pr: lgtm
action: merge
|
Breaking changes message? Or is the plan to wait until the re-export is removed? |
|
It should be a deprecation notice in the next release |
jelbourn
force-pushed
the
focos-trap-auto-capture
branch
from
87bd95e to
d38ea13
Compare
This also renames "FocusTrapDirective" to "CdkTrapFocus" and re-exports it under the old name.
jelbourn
force-pushed
the
focos-trap-auto-capture
branch
from
d38ea13 to
8a781b5
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
5 participants
This also renames "FocusTrapDirective" to "CdkTrapFocus" and re-exports it under the old name.