fix(overlay): disposed overlays not removed from the key event stack #8226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
crisbeto
force-pushed
the
overlay-dispose-key-events
branch
from
ad2f52f to
0550aec
Compare
crisbeto
force-pushed
the
overlay-dispose-key-events
branch
from
0550aec to
5d1f49c
Compare
|
@crisbeto looks like there are some CI failures after rebasing- probably some conflict with an earlier PR. Will catch this one in a subsequent sync |
crisbeto
force-pushed
the
overlay-dispose-key-events
branch
from
5d1f49c to
1aa5f16
Compare
Fixes overlays that are removed via `dispose` without being `detached` first not being removed from the stack inside the `OverlayKeyboardDispatcher`, causing them to block events for any subsequent overlays.
crisbeto
force-pushed
the
overlay-dispose-key-events
branch
from
1aa5f16 to
f64fb01
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes overlays that are removed via
disposewithout beingdetachedfirst not being removed from the stack inside theOverlayKeyboardDispatcher, causing them to block events for any subsequent overlays.