Skip to content

test: add more find and fix tests for repair tools #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jan 17, 2025
Merged

test: add more find and fix tests for repair tools #1645

merged 15 commits into from
Jan 17, 2025

Conversation

@RyanJWard
Copy link
Contributor

@RyanJWard RyanJWard commented Jan 16, 2025 •
edited by jonahrb
Loading

Description

Add find and fix tests for: duplicate faces, extra edges, inexact edges. Added validations to ensure the fix commands worked.

Issue linked

Expand testing coverage

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RyanJWard RyanJWard requested a review from a team as a code owner January 16, 2025 18:21
@jonahrb jonahrb changed the title Test/add more find and fix tests part1 test: add more find and fix tests part1 Jan 16, 2025
@jonahrb jonahrb changed the title test: add more find and fix tests part1 test: add more find and fix tests for repair tools Jan 16, 2025
RobPasMue
RobPasMue approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for adding these tests @RyanJWard!

@RobPasMue RobPasMue enabled auto-merge (squash) January 17, 2025 15:30
@RobPasMue RobPasMue merged commit 4993883 into blitz Jan 17, 2025
24 of 26 checks passed
@RobPasMue RobPasMue deleted the test/AddMoreFindAndFixTestsPart1 branch January 17, 2025 19:55
RobPasMue pushed a commit that referenced this pull request Jan 20, 2025
@RyanJWard @pre-commit-ci
@pyansys-ci-bot @jonahrb @RobPasMue
test: add more find and fix tests for repair tools (#1645)
ec8d992 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: jonahrb <[email protected]>
Co-authored-by: Jonah Boling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@jonahrb jonahrb jonahrb approved these changes

Assignees

@RyanJWard RyanJWard

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RyanJWard @RobPasMue @jonahrb @pyansys-ci-bot