Skip to content

feat: create circular and fill patterns #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jan 20, 2025
Merged

feat: create circular and fill patterns #1653

merged 15 commits into from
Jan 20, 2025

Conversation

@jonahrb
Copy link
Contributor

@jonahrb jonahrb commented Jan 17, 2025 •
edited
Loading

Description

Create circular patterns and fill patterns. Also update fill patterns to fill a face that changes in size.

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jonahrb jonahrb self-assigned this Jan 17, 2025
@jonahrb jonahrb requested a review from a team as a code owner January 17, 2025 18:45
@jonahrb jonahrb changed the base branch from main to blitz January 17, 2025 18:45
@github-actions github-actions bot added the enhancement New features or code improvements label Jan 17, 2025
RobPasMue
RobPasMue requested changes Jan 20, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments - once answered/addressed, I will approve

@jonahrb jonahrb requested a review from RobPasMue January 20, 2025 13:33
RobPasMue
RobPasMue approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobPasMue RobPasMue enabled auto-merge (squash) January 20, 2025 14:10
@RobPasMue RobPasMue merged commit 0ebf4b2 into blitz Jan 20, 2025
25 of 27 checks passed
@RobPasMue RobPasMue deleted the feat/create-more-patterns branch January 20, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees

@jonahrb jonahrb

Labels

enhancement New features or code improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonahrb @RobPasMue @pyansys-ci-bot