-
Notifications
You must be signed in to change notification settings - Fork 22
feat: is_core_service BackendType static method #1692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small comment - otherwise LGTM!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1692 +/- ##
==========================================
- Coverage 91.44% 91.37% -0.07%
==========================================
Files 87 87
Lines 7131 7143 +12
==========================================
+ Hits 6521 6527 +6
- Misses 610 616 +6 ☔ View full report in Codecov by Sentry. |
Description
Implement the 3 new backend types: Discovery Headless, CoreService on Linux and CoreService on Windows
Implement a method to determine whether the backend if of CoreService Kind
Rename skip_if_linux method skip_if_core_service
adapt comments
Checklist
feat: extrude circle to cylinder)