Skip to content

Conversation

@b-matteo
Copy link
Contributor

@b-matteo b-matteo commented Jan 27, 2025

Description

Implement the 3 new backend types: Discovery Headless, CoreService on Linux and CoreService on Windows
Implement a method to determine whether the backend if of CoreService Kind
Rename skip_if_linux method skip_if_core_service
adapt comments

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@b-matteo b-matteo added enhancement New features or code improvements maintenance Package and maintenance related testing Anything related to tests labels Jan 27, 2025
@b-matteo b-matteo self-assigned this Jan 27, 2025
@b-matteo b-matteo requested a review from a team as a code owner January 27, 2025 10:19
@github-actions github-actions bot removed maintenance Package and maintenance related testing Anything related to tests labels Jan 27, 2025
@github-actions github-actions bot added the maintenance Package and maintenance related label Jan 27, 2025
RobPasMue
RobPasMue previously approved these changes Jan 27, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment - otherwise LGTM!

@codecov
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 91.37%. Comparing base (082ea4d) to head (bfc340f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/connection/client.py 0.00% 6 Missing ⚠️
...ansys/geometry/core/connection/product_instance.py 0.00% 1 Missing ⚠️
src/ansys/geometry/core/modeler.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1692      +/-   ##
==========================================
- Coverage   91.44%   91.37%   -0.07%     
==========================================
  Files          87       87              
  Lines        7131     7143      +12     
==========================================
+ Hits         6521     6527       +6     
- Misses        610      616       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue changed the title feat: iscoreservice backentype feat: is_core_service BackendType static method Jan 27, 2025
RobPasMue
RobPasMue previously approved these changes Jan 27, 2025
@RobPasMue RobPasMue enabled auto-merge (squash) January 27, 2025 12:50
@RobPasMue RobPasMue merged commit 14ca699 into main Jan 27, 2025
45 of 47 checks passed
@RobPasMue RobPasMue deleted the feat/iscoreservice_backentype branch January 27, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants