Skip to content

Conversation

@jacobrkerstetter
Copy link
Contributor

@jacobrkerstetter jacobrkerstetter commented Mar 10, 2025

Description

  • Created enhanced class BoundingBox for 3D bounding box representations
  • Used by face, edge and body classes as a property
  • Added tests for math and design
  • Deprecated BoundingBox2D class

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Mar 10, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner March 10, 2025 13:58
@github-actions github-actions bot added testing Anything related to tests enhancement New features or code improvements labels Mar 10, 2025
@codecov
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 96.59091% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.64%. Comparing base (0f0ea97) to head (8110715).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/math/bbox.py 95.91% 2 Missing ⚠️
src/ansys/geometry/core/designer/body.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1805      +/-   ##
==========================================
+ Coverage   90.58%   90.64%   +0.05%     
==========================================
  Files          92       92              
  Lines        8480     8559      +79     
==========================================
+ Hits         7682     7758      +76     
- Misses        798      801       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) March 10, 2025 14:50
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - just left a few comments =) re-request review once addressed

@RobPasMue RobPasMue disabled auto-merge March 10, 2025 20:38
@RobPasMue RobPasMue enabled auto-merge (squash) March 10, 2025 20:38
@RobPasMue RobPasMue merged commit bc8822a into main Mar 10, 2025
46 of 49 checks passed
@RobPasMue RobPasMue deleted the feat/enhanced_bounding_boxes branch March 10, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants