-
Notifications
You must be signed in to change notification settings - Fork 22
feat: enhanced 3D bounding box implementation #1805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
deprecated BoundingBox2D
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1805 +/- ##
==========================================
+ Coverage 90.58% 90.64% +0.05%
==========================================
Files 92 92
Lines 8480 8559 +79
==========================================
+ Hits 7682 7758 +76
- Misses 798 801 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good - just left a few comments =) re-request review once addressed
… feat/enhanced_bounding_boxes
…ys/pyansys-geometry into feat/enhanced_bounding_boxes # Conflicts: # src/ansys/geometry/core/math/bbox.py
…ys/pyansys-geometry into feat/enhanced_bounding_boxes
Description
Issue linked
Checklist
feat: extrude circle to cylinder)