Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
b827101
ci: simplify blitz ci
RobPasMue Mar 10, 2025
7039876
fix: translating sketch issues when using a custom default unit (#1808)
RobPasMue Mar 10, 2025
f26f02c
feat: matrix helper methods (#1806)
umutsoysalansys Mar 11, 2025
179686b
fix: edge start and end were not being mapped correctly (#1816)
RobPasMue Mar 11, 2025
c62be98
added component name setter and tested
jacobrkerstetter Mar 12, 2025
a25e91e
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] Mar 12, 2025
5782122
chore: adding changelog file 1820.added.md [dependabot-skip]
pyansys-ci-bot Mar 12, 2025
6e1d0e7
ci: simplify blitz ci
RobPasMue Mar 10, 2025
c01276f
fix: translating sketch issues when using a custom default unit (#1808)
RobPasMue Mar 10, 2025
b10fb50
feat: matrix helper methods (#1806)
umutsoysalansys Mar 11, 2025
eb8b206
fix: edge start and end were not being mapped correctly (#1816)
RobPasMue Mar 11, 2025
9389ba5
ci: fix ci/cd
RobPasMue Mar 12, 2025
03aab27
Merge branch 'blitz' into feat/object_name_setters
RobPasMue Mar 12, 2025
dc21a1e
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] Mar 12, 2025
f749b98
added server side reflection of changes
jacobrkerstetter Mar 12, 2025
650eeff
setting name for components on server-side
jacobrkerstetter Mar 12, 2025
151eabe
Merge branch 'feat/object_name_setters' of https://github.com/ansys/p…
jacobrkerstetter Mar 12, 2025
7aa6ca5
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] Mar 12, 2025
917d18f
bumping api package version
jacobrkerstetter Mar 12, 2025
5389df7
Merge branch 'feat/object_name_setters' of https://github.com/ansys/p…
jacobrkerstetter Mar 12, 2025
abc6c53
chore: auto fixes from pre-commit hooks
pre-commit-ci[bot] Mar 12, 2025
6a021d7
Update src/ansys/geometry/core/designer/component.py
RobPasMue Mar 12, 2025
8968cc9
Merge branch 'blitz' into feat/object_name_setters
RobPasMue Mar 12, 2025
9d01ef1
Update .github/workflows/ci_cd.yml
RobPasMue Mar 12, 2025
ce73403
Update .github/workflows/ci_cd.yml
RobPasMue Mar 12, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.d/1820.added.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
component name setting
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ classifiers = [
]

dependencies = [
"ansys-api-geometry==0.4.46",
"ansys-api-geometry==0.4.47",
"ansys-tools-path>=0.3,<1",
"attrs!=24.3.0",
"beartype>=0.11.0,<0.20",
Expand Down
16 changes: 15 additions & 1 deletion src/ansys/geometry/core/designer/component.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
SetSharedTopologyRequest,
)
from ansys.api.geometry.v0.components_pb2_grpc import ComponentsStub
from ansys.api.geometry.v0.models_pb2 import Direction, Line, TrimmedCurveList
from ansys.api.geometry.v0.models_pb2 import Direction, Line, SetObjectNameRequest, TrimmedCurveList
from ansys.geometry.core.connection.client import GrpcClient
from ansys.geometry.core.connection.conversions import (
grpc_matrix_to_matrix,
Expand Down Expand Up @@ -266,6 +266,20 @@ def name(self) -> str:
"""Name of the component."""
return self._name

@name.setter
def name(self, value: str) -> None:
"""Set the name of the component."""
self.set_name(value)

@protect_grpc
@check_input_types
@min_backend_version(25, 2, 0)
def set_name(self, name: str) -> None:
"""Set the name of the component."""
self._grpc_client.log.debug(f"Renaming component {self.id} from '{self.name}' to '{name}'.")
self._component_stub.SetName(SetObjectNameRequest(id=self._grpc_id, name=name))
self._name = name

@property
def instance_name(self) -> str:
"""Name of the component instance."""
Expand Down
4 changes: 3 additions & 1 deletion src/ansys/geometry/core/designer/edge.py
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,9 @@ def end(self) -> Point3D:
# Only for versions earlier than 24.2.0 (before the introduction of the shape property)
self._grpc_client.log.debug("Requesting edge end point from server.")
response = self._edges_stub.GetStartAndEndPoints(self._grpc_id)
return Point3D([response.end.x, response.end.y, response.end.z])
return Point3D(
[response.end.x, response.end.y, response.end.z], unit=DEFAULT_UNITS.SERVER_LENGTH
)

@property
@protect_grpc
Expand Down
11 changes: 11 additions & 0 deletions tests/integration/test_design.py
Original file line number Diff line number Diff line change
Expand Up @@ -3192,6 +3192,17 @@ def test_set_face_color(modeler: Modeler):
faces[3].opacity = 255


def test_set_component_name(modeler: Modeler):
"""Test the setting of component names."""

design = modeler.create_design("ComponentNameTest")
component = design.add_component("Component1")
assert component.name == "Component1"

component.name = "ChangedComponentName"
assert component.name == "ChangedComponentName"


def test_get_face_bounding_box(modeler: Modeler):
"""Test getting the bounding box of a face."""
design = modeler.create_design("face_bounding_box")
Expand Down
Loading