From 42ad050d226fdba5ba9838ca01569cf8af74694a Mon Sep 17 00:00:00 2001 From: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com> Date: Thu, 25 Sep 2025 07:58:07 +0200 Subject: [PATCH 1/7] ci: backwards compatibility changes on Docker images --- .github/workflows/backwards_compatibility.yml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/backwards_compatibility.yml b/.github/workflows/backwards_compatibility.yml index 1ba830dc9c..9dee1ea2e3 100644 --- a/.github/workflows/backwards_compatibility.yml +++ b/.github/workflows/backwards_compatibility.yml @@ -95,7 +95,15 @@ jobs: - name: Start Geometry service and verify start run: | .\.venv\Scripts\Activate.ps1 - docker run --detach --name ${{ env.GEO_CONT_NAME }} -e LICENSE_SERVER=${{ env.ANSRV_GEO_LICENSE_SERVER }} -p ${{ env.ANSRV_GEO_PORT }}:50051 ${{ env.ANSRV_GEO_IMAGE }}:${{ matrix.image-tag }} ${{ secrets.TRANSPORT_MODE_SELECTION }} + # If on 24.1, 24.2 and 25.1, we need to define the SERVER_ENDPOINT variable + if (${{ matrix.backend-version }} -in @("24.1", "24.2", "25.1")) { + $env:SERVER_ENDPOINT = "-e SERVER_ENDPOINT=0.0.0.0@50051" + echo "Adding SERVER_ENDPOINT variable for backend version ${{ matrix.backend-version }}" + echo "SERVER_ENDPOINT variable set to: $env:SERVER_ENDPOINT" + } else { + $env:SERVER_ENDPOINT = "" + } + docker run --detach --name ${{ env.GEO_CONT_NAME }} -e LICENSE_SERVER=${{ env.ANSRV_GEO_LICENSE_SERVER }} $env:SERVER_ENDPOINT -p ${{ env.ANSRV_GEO_PORT }}:50051 ${{ env.ANSRV_GEO_IMAGE }}:${{ matrix.image-tag }} ${{ secrets.TRANSPORT_MODE_SELECTION }} Start-Sleep -Seconds 10 python -c "from ansys.geometry.core.connection.validate import validate; validate()" From 6dc0daa009271adb3c295c85116b1b83ec2e3444 Mon Sep 17 00:00:00 2001 From: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Date: Thu, 25 Sep 2025 05:59:45 +0000 Subject: [PATCH 2/7] chore: adding changelog file 2256.maintenance.md [dependabot-skip] --- doc/changelog.d/2256.maintenance.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 doc/changelog.d/2256.maintenance.md diff --git a/doc/changelog.d/2256.maintenance.md b/doc/changelog.d/2256.maintenance.md new file mode 100644 index 0000000000..06404f8a55 --- /dev/null +++ b/doc/changelog.d/2256.maintenance.md @@ -0,0 +1 @@ +Backwards compatibility changes on Docker images From 33d51c0d76776e7f9739d9295d337206f6fb8b65 Mon Sep 17 00:00:00 2001 From: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com> Date: Thu, 25 Sep 2025 08:33:22 +0200 Subject: [PATCH 3/7] ci: trial --- .github/workflows/backwards_compatibility.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/backwards_compatibility.yml b/.github/workflows/backwards_compatibility.yml index 9dee1ea2e3..4e5171802e 100644 --- a/.github/workflows/backwards_compatibility.yml +++ b/.github/workflows/backwards_compatibility.yml @@ -97,13 +97,11 @@ jobs: .\.venv\Scripts\Activate.ps1 # If on 24.1, 24.2 and 25.1, we need to define the SERVER_ENDPOINT variable if (${{ matrix.backend-version }} -in @("24.1", "24.2", "25.1")) { - $env:SERVER_ENDPOINT = "-e SERVER_ENDPOINT=0.0.0.0@50051" echo "Adding SERVER_ENDPOINT variable for backend version ${{ matrix.backend-version }}" - echo "SERVER_ENDPOINT variable set to: $env:SERVER_ENDPOINT" + docker run --detach --name ${{ env.GEO_CONT_NAME }} -e LICENSE_SERVER=${{ env.ANSRV_GEO_LICENSE_SERVER }} -e SERVER_ENDPOINT=0.0.0.0@50051 -p ${{ env.ANSRV_GEO_PORT }}:50051 ${{ env.ANSRV_GEO_IMAGE }}:${{ matrix.image-tag }} ${{ secrets.TRANSPORT_MODE_SELECTION }} } else { - $env:SERVER_ENDPOINT = "" + docker run --detach --name ${{ env.GEO_CONT_NAME }} -e LICENSE_SERVER=${{ env.ANSRV_GEO_LICENSE_SERVER }} -p ${{ env.ANSRV_GEO_PORT }}:50051 ${{ env.ANSRV_GEO_IMAGE }}:${{ matrix.image-tag }} ${{ secrets.TRANSPORT_MODE_SELECTION }} } - docker run --detach --name ${{ env.GEO_CONT_NAME }} -e LICENSE_SERVER=${{ env.ANSRV_GEO_LICENSE_SERVER }} $env:SERVER_ENDPOINT -p ${{ env.ANSRV_GEO_PORT }}:50051 ${{ env.ANSRV_GEO_IMAGE }}:${{ matrix.image-tag }} ${{ secrets.TRANSPORT_MODE_SELECTION }} Start-Sleep -Seconds 10 python -c "from ansys.geometry.core.connection.validate import validate; validate()" From d1e4d124c26b64be2da673c65e59168dc55ffb58 Mon Sep 17 00:00:00 2001 From: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com> Date: Thu, 25 Sep 2025 08:41:04 +0200 Subject: [PATCH 4/7] ci: trial 2 --- .github/workflows/backwards_compatibility.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/backwards_compatibility.yml b/.github/workflows/backwards_compatibility.yml index 4e5171802e..18f6d1c8f7 100644 --- a/.github/workflows/backwards_compatibility.yml +++ b/.github/workflows/backwards_compatibility.yml @@ -98,7 +98,7 @@ jobs: # If on 24.1, 24.2 and 25.1, we need to define the SERVER_ENDPOINT variable if (${{ matrix.backend-version }} -in @("24.1", "24.2", "25.1")) { echo "Adding SERVER_ENDPOINT variable for backend version ${{ matrix.backend-version }}" - docker run --detach --name ${{ env.GEO_CONT_NAME }} -e LICENSE_SERVER=${{ env.ANSRV_GEO_LICENSE_SERVER }} -e SERVER_ENDPOINT=0.0.0.0@50051 -p ${{ env.ANSRV_GEO_PORT }}:50051 ${{ env.ANSRV_GEO_IMAGE }}:${{ matrix.image-tag }} ${{ secrets.TRANSPORT_MODE_SELECTION }} + docker run --detach --name ${{ env.GEO_CONT_NAME }} -e LICENSE_SERVER=${{ env.ANSRV_GEO_LICENSE_SERVER }} -e SERVER_ENDPOINT=50051@0.0.0.0 -p ${{ env.ANSRV_GEO_PORT }}:50051 ${{ env.ANSRV_GEO_IMAGE }}:${{ matrix.image-tag }} ${{ secrets.TRANSPORT_MODE_SELECTION }} } else { docker run --detach --name ${{ env.GEO_CONT_NAME }} -e LICENSE_SERVER=${{ env.ANSRV_GEO_LICENSE_SERVER }} -p ${{ env.ANSRV_GEO_PORT }}:50051 ${{ env.ANSRV_GEO_IMAGE }}:${{ matrix.image-tag }} ${{ secrets.TRANSPORT_MODE_SELECTION }} } From 8fd492b7d33563baa770c818af4f56890065be9d Mon Sep 17 00:00:00 2001 From: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com> Date: Thu, 25 Sep 2025 08:47:58 +0200 Subject: [PATCH 5/7] ci: cleanup --- .github/workflows/backwards_compatibility.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/backwards_compatibility.yml b/.github/workflows/backwards_compatibility.yml index 18f6d1c8f7..2a2bd078dc 100644 --- a/.github/workflows/backwards_compatibility.yml +++ b/.github/workflows/backwards_compatibility.yml @@ -97,11 +97,13 @@ jobs: .\.venv\Scripts\Activate.ps1 # If on 24.1, 24.2 and 25.1, we need to define the SERVER_ENDPOINT variable if (${{ matrix.backend-version }} -in @("24.1", "24.2", "25.1")) { + $env:SERVER_ENDPOINT = "-e SERVER_ENDPOINT=50051@0.0.0.0" echo "Adding SERVER_ENDPOINT variable for backend version ${{ matrix.backend-version }}" - docker run --detach --name ${{ env.GEO_CONT_NAME }} -e LICENSE_SERVER=${{ env.ANSRV_GEO_LICENSE_SERVER }} -e SERVER_ENDPOINT=50051@0.0.0.0 -p ${{ env.ANSRV_GEO_PORT }}:50051 ${{ env.ANSRV_GEO_IMAGE }}:${{ matrix.image-tag }} ${{ secrets.TRANSPORT_MODE_SELECTION }} + echo "SERVER_ENDPOINT variable set to: $env:SERVER_ENDPOINT" } else { - docker run --detach --name ${{ env.GEO_CONT_NAME }} -e LICENSE_SERVER=${{ env.ANSRV_GEO_LICENSE_SERVER }} -p ${{ env.ANSRV_GEO_PORT }}:50051 ${{ env.ANSRV_GEO_IMAGE }}:${{ matrix.image-tag }} ${{ secrets.TRANSPORT_MODE_SELECTION }} + $env:SERVER_ENDPOINT = "" } + docker run --detach --name ${{ env.GEO_CONT_NAME }} -e LICENSE_SERVER=${{ env.ANSRV_GEO_LICENSE_SERVER }} $env:SERVER_ENDPOINT -p ${{ env.ANSRV_GEO_PORT }}:50051 ${{ env.ANSRV_GEO_IMAGE }}:${{ matrix.image-tag }} ${{ secrets.TRANSPORT_MODE_SELECTION }} Start-Sleep -Seconds 10 python -c "from ansys.geometry.core.connection.validate import validate; validate()" From edaca7cee434f45d3be2543778824aea2478872d Mon Sep 17 00:00:00 2001 From: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com> Date: Thu, 25 Sep 2025 08:49:12 +0200 Subject: [PATCH 6/7] chore: cleanup Dockerfile --- docker/windows/dms/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docker/windows/dms/Dockerfile b/docker/windows/dms/Dockerfile index 4a2396f130..4ea19bfc43 100644 --- a/docker/windows/dms/Dockerfile +++ b/docker/windows/dms/Dockerfile @@ -26,7 +26,7 @@ RUN mkdir tmp_folder && \ # Defining environment variables ENV LICENSE_SERVER="" -ENV SERVER_ENDPOINT="0.0.0.0:50051" +ENV SERVER_ENDPOINT="50051@0.0.0.0" ENV ENABLE_TRACE=0 ENV LOG_LEVEL=2 ENV AWP_ROOT252=C:/app/unified From 8616878568eb6c635aaab5cd6f9e3e842f396084 Mon Sep 17 00:00:00 2001 From: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com> Date: Thu, 25 Sep 2025 09:01:55 +0200 Subject: [PATCH 7/7] ci: cleanup --- .github/workflows/backwards_compatibility.yml | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/.github/workflows/backwards_compatibility.yml b/.github/workflows/backwards_compatibility.yml index 2a2bd078dc..25558f8891 100644 --- a/.github/workflows/backwards_compatibility.yml +++ b/.github/workflows/backwards_compatibility.yml @@ -92,18 +92,17 @@ jobs: docker rm $dockerContainers } + - name: Define SERVER_ENDPOINT variable if needed + if: matrix.backend-version == '24.1' || matrix.backend-version == '24.2' || matrix.backend-version == '25.1' + run: | + $env:SERVER_ENDPOINT = "-e SERVER_ENDPOINT=50051@0.0.0.0" + echo "SERVER_ENDPOINT variable set to: $env:SERVER_ENDPOINT" + echo "SERVER_ENDPOINT=$env:SERVER_ENDPOINT" | Out-File -FilePath $env:GITHUB_ENV -Append + - name: Start Geometry service and verify start run: | .\.venv\Scripts\Activate.ps1 - # If on 24.1, 24.2 and 25.1, we need to define the SERVER_ENDPOINT variable - if (${{ matrix.backend-version }} -in @("24.1", "24.2", "25.1")) { - $env:SERVER_ENDPOINT = "-e SERVER_ENDPOINT=50051@0.0.0.0" - echo "Adding SERVER_ENDPOINT variable for backend version ${{ matrix.backend-version }}" - echo "SERVER_ENDPOINT variable set to: $env:SERVER_ENDPOINT" - } else { - $env:SERVER_ENDPOINT = "" - } - docker run --detach --name ${{ env.GEO_CONT_NAME }} -e LICENSE_SERVER=${{ env.ANSRV_GEO_LICENSE_SERVER }} $env:SERVER_ENDPOINT -p ${{ env.ANSRV_GEO_PORT }}:50051 ${{ env.ANSRV_GEO_IMAGE }}:${{ matrix.image-tag }} ${{ secrets.TRANSPORT_MODE_SELECTION }} + docker run --detach --name ${{ env.GEO_CONT_NAME }} -e LICENSE_SERVER=${{ env.ANSRV_GEO_LICENSE_SERVER }} ${{ env.SERVER_ENDPOINT }} -p ${{ env.ANSRV_GEO_PORT }}:50051 ${{ env.ANSRV_GEO_IMAGE }}:${{ matrix.image-tag }} ${{ secrets.TRANSPORT_MODE_SELECTION }} Start-Sleep -Seconds 10 python -c "from ansys.geometry.core.connection.validate import validate; validate()"