Skip to content

Conversation

@jacobrkerstetter
Copy link
Contributor

Description

  • addresses issue where tessellation fails to convert from gRPC object to Polydata when tessellation response data has empty vertices/faces arrays

Issue linked

TFS Bug 1335500

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Oct 6, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner October 6, 2025 15:45
@github-actions github-actions bot added the bug Something isn't working label Oct 6, 2025
@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.50%. Comparing base (782aa66) to head (0977c40).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ys/geometry/core/_grpc/_services/v0/conversions.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2284      +/-   ##
==========================================
- Coverage   94.50%   94.50%   -0.01%     
==========================================
  Files         169      169              
  Lines       11126    11128       +2     
==========================================
+ Hits        10515    10516       +1     
- Misses        611      612       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test this somehow?

@jacobrkerstetter jacobrkerstetter merged commit 9e8e1be into main Oct 7, 2025
57 checks passed
@jacobrkerstetter jacobrkerstetter deleted the fix/empty_tessellation_data branch October 7, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants