Skip to content
This repository was archived by the owner on Jan 9, 2020. It is now read-only.

Commit e7a460e

Browse files
committed
Address PR comments.
1 parent 7b5b13a commit e7a460e

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/kubernetes/KubernetesExternalShuffleClientImpl.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public class KubernetesExternalShuffleClientImpl
4343
.getLogger(KubernetesExternalShuffleClientImpl.class);
4444

4545
/**
46-
* Creates an Kubernetes external shuffle client that wraps the {@link ExternalShuffleClient}.
46+
* Creates a Kubernetes external shuffle client that wraps the {@link ExternalShuffleClient}.
4747
* Please refer to docs on {@link ExternalShuffleClient} for more information.
4848
*/
4949
public KubernetesExternalShuffleClientImpl(
@@ -74,9 +74,4 @@ public void onFailure(Throwable e) {
7474
"Please manually remove shuffle data after driver exit. Error: " + e);
7575
}
7676
}
77-
78-
@Override
79-
public void close() {
80-
super.close();
81-
}
8277
}

resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/kubernetes/KubernetesClusterSchedulerBackend.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -463,10 +463,10 @@ private[spark] class KubernetesClusterSchedulerBackend(
463463
.withName(runningExecutorsToPods(executorId).getMetadata.getName)
464464
.get()
465465
}
466-
val shuffleSpecifiProperties = shuffleManager.get
466+
val shuffleSpecificProperties = shuffleManager.get
467467
.getShuffleServiceConfigurationForExecutor(runningExecutorPod)
468468
val reply = SparkAppConfig(
469-
sparkProperties ++ shuffleSpecifiProperties,
469+
sparkProperties ++ shuffleSpecificProperties,
470470
SparkEnv.get.securityManager.getIOEncryptionKey())
471471
context.reply(reply)
472472
}

0 commit comments

Comments
 (0)