[MINOR]: Parametrize sort-preservation tests to exercise all situations (unbounded/bounded sources and flag behavior) #8575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozankabak
changed the title
7 tasks
alamb
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Looks good to me -- thank you @mustafasrepo
Given this is expanding test coverage I am merging it in now (and we can address any additional suggestions in follow on PRs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
With the PR8573,
is_infiniteflag is removed. Some of the changes in the PR8573 changed tests such that the we no longer exercise the interaction between sort preservation flag with boundedness properties of sources. This PR changes these tests so that the tests exercise all possible situations.What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?