General virtual columns support + row numbers as a first use-case #8715
+750
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: scovich <[email protected]>
…eature tests pass
vustef
commented
Oct 27, 2025
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| use arrow_schema::{DataType, Field, Fields, SchemaBuilder}; |
| #[cfg(test)] | ||
| mod test_util; | ||
|
|
||
| // Note that this crate is public under the `experimental` feature flag. |
| } | ||
|
|
||
| fn skip_records(&mut self, num_records: usize) -> Result<usize> { | ||
| // TODO: Use advance_by when it stabilizes to improve performance |
| #[cfg(feature = "encryption")] | ||
| pub(crate) file_decryption_properties: Option<Arc<FileDecryptionProperties>>, | ||
|
|
||
| virtual_columns: Vec<Field> |
| /// let virtual_columns = vec![Field::new("row_number", ArrowDataType::Int64, false).with_extension_type(RowNumber)]; | ||
| /// let options = ArrowReaderOptions::new().with_virtual_columns(virtual_columns); | ||
| pub fn with_virtual_columns(self, virtual_columns: Vec<Field>) -> Self { | ||
| // TODO @vustef: Make sure the passed fields are virtual columns. |
There was a problem hiding this comment.
I still have a bunch of TODOs to address
| } | ||
|
|
||
| fn row_groups(&self) -> Box<dyn Iterator<Item = &RowGroupMetaData> + '_> { | ||
| Box::new(std::iter::once(self.metadata.row_group(self.row_group_idx))) |
There was a problem hiding this comment.
this duplicates a lot, not sure if anything can be done here
| /// - If nullable: def_level = parent_def_level + 1 | ||
| /// - If required: def_level = parent_def_level | ||
| /// - rep_level = parent_rep_level (virtual fields are not repeated) | ||
| fn convert_virtual_field( |
There was a problem hiding this comment.
the name used here is not aligned with what other convert_ functions do
…hen metadata parsing may skip row groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #7307.
Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.
Rationale for this change
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
What changes are included in this PR?
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
Are these changes tested?
We typically require tests for all PRs in order to:
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
Are there any user-facing changes?
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please call them out.