Skip to content

Conversation

@kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Oct 3, 2025

Rationale for this change

macos-13 github runners are https://github.blog/changelog/2025-09-19-github-actions-macos-13-runner-image-is-closing-down/

This PR replaces macos-13 with macos-15-intel based on recommendations here

What changes are included in this PR?

Change all references of macos-13 to macos-15-intel

Are these changes tested?

Yes, CI

Are there any user-facing changes?

This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)

This PR contains a "Critical Fix". (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)

@github-actions
Copy link

github-actions bot commented Oct 3, 2025

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@github-actions github-actions bot added the awaiting review Awaiting review label Oct 3, 2025
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevinjqliu for giving this a try!

matrix:
platform:
- { runs_on: macos-13, arch: "x86_64" }
- { runs_on: macos-latest, arch: "arm64" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still want to test with x86_64 architecture we probably should use the new macos-15-intel runners, see:
https://github.com/actions/runner-images?tab=readme-ov-file#available-images

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes good catch! ty

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Oct 3, 2025
@kevinjqliu kevinjqliu force-pushed the kevinjqliu/macos-13-is-deprecated branch from a3e410b to c61c40c Compare October 4, 2025 21:44
@kevinjqliu kevinjqliu requested a review from raulcd October 4, 2025 21:45
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Oct 4, 2025
@kevinjqliu kevinjqliu force-pushed the kevinjqliu/macos-13-is-deprecated branch from c61c40c to a9ffb5b Compare October 4, 2025 21:46
@raulcd
Copy link
Member

raulcd commented Oct 13, 2025

@github-actions crossbow submit wheel-macos-monterey-*-amd64 verify-rc-source-macos

@github-actions
Copy link

Revision: a9ffb5b

Submitted crossbow builds: ursacomputing/crossbow @ actions-9c62fc0d9f

Task Status
verify-rc-source-cpp-macos-amd64 GitHub Actions
verify-rc-source-cpp-macos-arm64 GitHub Actions
verify-rc-source-cpp-macos-conda-amd64 GitHub Actions
verify-rc-source-integration-macos-amd64 GitHub Actions
verify-rc-source-integration-macos-arm64 GitHub Actions
verify-rc-source-integration-macos-conda-amd64 GitHub Actions
verify-rc-source-python-macos-amd64 GitHub Actions
verify-rc-source-python-macos-arm64 GitHub Actions
verify-rc-source-python-macos-conda-amd64 GitHub Actions
verify-rc-source-ruby-macos-amd64 GitHub Actions
verify-rc-source-ruby-macos-arm64 GitHub Actions
wheel-macos-monterey-cp310-cp310-amd64 GitHub Actions
wheel-macos-monterey-cp311-cp311-amd64 GitHub Actions
wheel-macos-monterey-cp312-cp312-amd64 GitHub Actions
wheel-macos-monterey-cp313-cp313-amd64 GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64 GitHub Actions

@raulcd
Copy link
Member

raulcd commented Oct 23, 2025

The macOS wheels seem to be failing due to mono being missing:

 error: Could not fetch mono. You may be able to install this tool via your system package manager (brew install mono).
note: updating vcpkg by rerunning bootstrap-vcpkg may resolve this failure.
arrow/ci/scripts/install_vcpkg.sh: line 79: Successfully: command not found

We could try adding mono here, even though we probably want to fix it on the ci/scripts/install_vcpkg.sh script:

diff --git a/dev/tasks/python-wheels/github.osx.yml b/dev/tasks/python-wheels/github.osx.yml
index ef8e90f412..9493dc1c3d 100644
--- a/dev/tasks/python-wheels/github.osx.yml
+++ b/dev/tasks/python-wheels/github.osx.yml
@@ -51,7 +51,7 @@ jobs:
 
       - name: Install System Dependencies
         run: |
-          brew install bash bison coreutils ninja
+          brew install bash bison coreutils ninja mono
           echo "$(brew --prefix bison)/bin" >> $GITHUB_PATH
 
       - name: Homebrew packages

There are also some Python failures which I am unsure if they are related or they were fixed in the past. Could you rebase and I'll trigger again the verify-rc-source-python-macos-* jobs?

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevinjqliu for this. Will you have some time to follow up the CI failures? Otherwise I can try to take some time later on

@raulcd raulcd changed the title infra: macos-13 is deprecated GH-47923: [CI] macos-13 runners are deprecated Oct 23, 2025
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Oct 23, 2025
@github-actions
Copy link

⚠️ GitHub issue #47923 has been automatically assigned in GitHub to PR creator.

@kevinjqliu kevinjqliu force-pushed the kevinjqliu/macos-13-is-deprecated branch from a9ffb5b to 8990f06 Compare October 25, 2025 00:31
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Oct 25, 2025
@kevinjqliu kevinjqliu force-pushed the kevinjqliu/macos-13-is-deprecated branch from 8990f06 to 3c4b2a4 Compare October 25, 2025 16:40
@kevinjqliu
Copy link
Contributor Author

Failed to verify release candidate. See /tmp/arrow-22.0.0.Zix5U for details.

for the 2 failed "Verify RC / APIT" tests

The C++ and Python failures are due to 1 failed test

@raulcd
Copy link
Member

raulcd commented Oct 27, 2025

@github-actions crossbow submit verify-rc-source-python-macos-*

@raulcd
Copy link
Member

raulcd commented Oct 27, 2025

@github-actions crossbow submit wheel-macos-monterey-cp310-cp310-amd64

@raulcd
Copy link
Member

raulcd commented Oct 28, 2025

@github-actions crossbow submit wheel-macos-monterey-cp310-cp310-amd64

@github-actions
Copy link

Revision: 9cab474

Submitted crossbow builds: ursacomputing/crossbow @ actions-6867856d91

Task Status
wheel-macos-monterey-cp310-cp310-amd64 GitHub Actions

@raulcd
Copy link
Member

raulcd commented Oct 29, 2025

@github-actions crossbow submit verify-rc-source-python-macos-*

@raulcd
Copy link
Member

raulcd commented Oct 29, 2025

wheels seem green now. Let's check the verification jobs, some of the failures have been fixed on main

@raulcd
Copy link
Member

raulcd commented Oct 29, 2025

@github-actions crossbow submit wheel-macos-monterey-*

@github-actions
Copy link

Revision: 9cab474

Submitted crossbow builds: ursacomputing/crossbow @ actions-ac8d15d638

Task Status
verify-rc-source-python-macos-amd64 GitHub Actions
verify-rc-source-python-macos-arm64 GitHub Actions
verify-rc-source-python-macos-conda-amd64 GitHub Actions

@github-actions
Copy link

Revision: 9cab474

Submitted crossbow builds: ursacomputing/crossbow @ actions-e9e41d3773

Task Status
wheel-macos-monterey-cp310-cp310-amd64 GitHub Actions
wheel-macos-monterey-cp310-cp310-arm64 GitHub Actions
wheel-macos-monterey-cp311-cp311-amd64 GitHub Actions
wheel-macos-monterey-cp311-cp311-arm64 GitHub Actions
wheel-macos-monterey-cp312-cp312-amd64 GitHub Actions
wheel-macos-monterey-cp312-cp312-arm64 GitHub Actions
wheel-macos-monterey-cp313-cp313-amd64 GitHub Actions
wheel-macos-monterey-cp313-cp313-arm64 GitHub Actions
wheel-macos-monterey-cp313-cp313t-amd64 GitHub Actions
wheel-macos-monterey-cp313-cp313t-arm64 GitHub Actions
wheel-macos-monterey-cp314-cp314-amd64 GitHub Actions
wheel-macos-monterey-cp314-cp314-arm64 GitHub Actions
wheel-macos-monterey-cp314-cp314t-amd64 GitHub Actions
wheel-macos-monterey-cp314-cp314t-arm64 GitHub Actions

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The verification failures are confusing as they seem to appear on both macos15-intel and macos-14-arm. The latest hasn't been modified.
Those failures are on some Python / pandas integration tests with registering / unregistering extension types which seems unlikely to be related to the change of underlying macos version.

I am happy to merge.

@kou thoughts?

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Oct 29, 2025
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... They aren't failed on main: https://lists.apache.org/thread/svj4vv6ot6yj9b5qgydcjrbzps3g957z

Could you rebase on main?

And could you update the PR description before we merge this? We'll use the PR description for commit message.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Oct 30, 2025
@kevinjqliu kevinjqliu force-pushed the kevinjqliu/macos-13-is-deprecated branch from 324171a to 6bdc0cf Compare October 30, 2025 02:19
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Oct 30, 2025
@kevinjqliu
Copy link
Contributor Author

rebased origin/main and updated the PR description

@github-actions
Copy link

⚠️ GitHub issue #47923 has been automatically assigned in GitHub to PR creator.

@raulcd
Copy link
Member

raulcd commented Oct 30, 2025

@github-actions crossbow submit verify-rc-source-python-macos-*

@github-actions
Copy link

Revision: 6bdc0cf

Submitted crossbow builds: ursacomputing/crossbow @ actions-e7168bd48b

Task Status
verify-rc-source-python-macos-amd64 GitHub Actions
verify-rc-source-python-macos-arm64 GitHub Actions
verify-rc-source-python-macos-conda-amd64 GitHub Actions

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found what the problem is on those jobs and is unrelated to the changes. The problem is with the fork.
PyArrow is being generated with the wrong version (hence triggering some old behavior on pandas). See:
pyarrow-12.0.0.dev5006+g6bdc0cf07
This is because the fork is missing the tags for the newer Arrow releases and it's unable to generate the correct version.

This is related to:

I realized when I created a different PR to try and understand the failure. I decided to cherry-pick the exact same 4 commits that are on this PR on top of current main and my testing PR was able to run all the verification jobs successfully:
#48007

That's when I tried to understand what was the difference with the remote.

I am happy to merge this.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Oct 31, 2025
@kou
Copy link
Member

kou commented Oct 31, 2025

Ah, it make sense.

@kevinjqliu Could you push tags in apache/arrow to your fork by git push --tags origin? Then we'll re-run the failed jobs.

@kevinjqliu kevinjqliu force-pushed the kevinjqliu/macos-13-is-deprecated branch from 6bdc0cf to e274f39 Compare November 2, 2025 00:33
@kevinjqliu
Copy link
Contributor Author

pushed all the tags to my fork, rebased one more time for good measure. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge Awaiting merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants