Adding global setting to scale noVNC console display

Author: davidjumani

server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManager.java

@@ -41,6 +41,9 @@ public interface ConsoleProxyManager extends Manager, ConsoleProxyService {
     public static final ConfigKey<Boolean> NoVncConsoleDefault = new ConfigKey<Boolean>("Advanced", Boolean.class, "novnc.console.default", "true",
         "If true, noVNC console will be default console for virtual machines", true);
 
+    public static final ConfigKey<Boolean> NoVncConsoleFullscreen = new ConfigKey<Boolean>("Advanced", Boolean.class, "novnc.console.fullscreen",
+        "true", "If true, noVNC console will be scaled to the browser resolution, making it fullscreen", true);
+
     public void setManagementState(ConsoleProxyManagementState state);
 
     public ConsoleProxyManagementState getManagementState();

server/src/main/java/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java

@@ -1755,7 +1755,7 @@ public String getConfigComponentName() {
 
     @Override
     public ConfigKey<?>[] getConfigKeys() {
-        return new ConfigKey<?>[] { NoVncConsoleDefault };
+        return new ConfigKey<?>[] { NoVncConsoleDefault, NoVncConsoleFullscreen };
     }
 
 }

server/src/main/java/com/cloud/servlet/ConsoleProxyServlet.java

@@ -486,6 +486,9 @@ private String composeConsoleAccessUrl(String rootUrl, VirtualMachine vm, HostVO
         } else {
             sb.append("/resource/noVNC/vnc_lite.html?port=" + ConsoleProxyManager.DEFAULT_NOVNC_PORT + "&token="
                 + encryptor.encryptObject(ConsoleProxyClientParam.class, param));
+            if (ConsoleProxyManager.NoVncConsoleFullscreen.value()) {
+                sb.append("&scale=true");
+            }
         }
 
         // for console access, we need guest OS type to help implement keyboard