CLOUDSTACK-7678:volumes are getting uploaded successfully with wrong

url.

Author: minchen07

engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java

@@ -125,8 +125,6 @@ public class VolumeServiceImpl implements VolumeService {
     @Inject
     VMTemplatePoolDao _tmpltPoolDao;
     @Inject
-    VolumeDao _volumeDao;
-    @Inject
     EndPointSelector _epSelector;
     @Inject
     HostDao _hostDao;
@@ -1021,7 +1019,7 @@ protected Void copyVolumeCallBack(AsyncCallbackDispatcher<VolumeServiceImpl, Cop
             }
             srcVolume.processEvent(Event.OperationSuccessed);
             destVolume.processEvent(Event.OperationSuccessed, result.getAnswer());
-            _volumeDao.updateUuid(srcVolume.getId(), destVolume.getId());
+            volDao.updateUuid(srcVolume.getId(), destVolume.getId());
             try {
                 destroyVolume(srcVolume.getId());
                 srcVolume = volFactory.getVolume(srcVolume.getId());
@@ -1226,10 +1224,16 @@ public AsyncCallFuture<VolumeApiResult> registerVolume(VolumeInfo volume, DataSt
 
     protected Void registerVolumeCallback(AsyncCallbackDispatcher<VolumeServiceImpl, CreateCmdResult> callback, CreateVolumeContext<VolumeApiResult> context) {
         CreateCmdResult result = callback.getResult();
+        VolumeObject vo = (VolumeObject)context.volume;
         try {
-            VolumeObject vo = (VolumeObject)context.volume;
             if (result.isFailed()) {
                 vo.processEvent(Event.OperationFailed);
+                // delete the volume entry from volumes table in case of failure
+                VolumeVO vol = volDao.findById(vo.getId());
+                if (vol != null) {
+                    volDao.remove(vo.getId());
+                }
+
             } else {
                 vo.processEvent(Event.OperationSuccessed, result.getAnswer());
 
@@ -1268,6 +1272,11 @@ protected Void registerVolumeCallback(AsyncCallbackDispatcher<VolumeServiceImpl,
 
         } catch (Exception e) {
             s_logger.error("register volume failed: ", e);
+            // delete the volume entry from volumes table in case of failure
+            VolumeVO vol = volDao.findById(vo.getId());
+            if (vol != null) {
+                volDao.remove(vo.getId());
+            }
             VolumeApiResult res = new VolumeApiResult(null);
             context.future.complete(res);
             return null;
@@ -1303,7 +1312,7 @@ public void resizeVolumeOnHypervisor(long volumeId, long newSize, long destHostI
             EndPoint ep = RemoteHostEndPoint.getHypervisorHostEndPoint(destHost);
 
             if (ep != null) {
-                VolumeVO volume = _volumeDao.findById(volumeId);
+                VolumeVO volume = volDao.findById(volumeId);
                 PrimaryDataStore primaryDataStore = this.dataStoreMgr.getPrimaryDataStore(volume.getPoolId());
                 ResizeVolumeCommand resizeCmd = new ResizeVolumeCommand(volume.getPath(), new StorageFilerTO(primaryDataStore), volume.getSize(), newSize, true, instanceName);
 
@@ -1375,7 +1384,7 @@ public void handleVolumeSync(DataStore store) {
                     List<VolumeDataStoreVO> dbVolumes = _volumeStoreDao.listByStoreId(storeId);
                     List<VolumeDataStoreVO> toBeDownloaded = new ArrayList<VolumeDataStoreVO>(dbVolumes);
                     for (VolumeDataStoreVO volumeStore : dbVolumes) {
-                        VolumeVO volume = _volumeDao.findById(volumeStore.getVolumeId());
+                        VolumeVO volume = volDao.findById(volumeStore.getVolumeId());
                         if (volume == null) {
                             s_logger.warn("Volume_store_ref shows that volume " + volumeStore.getVolumeId() + " is on image store " + storeId +
                                     ", but the volume is not found in volumes table, potentially some bugs in deleteVolume, so we just treat this volume to be deleted and mark it as destroyed");
@@ -1420,7 +1429,7 @@ public void handleVolumeSync(DataStore store) {
                                 if (volume.getSize() == 0) {
                                     // Set volume size in volumes table
                                     volume.setSize(volInfo.getSize());
-                                    _volumeDao.update(volumeStore.getVolumeId(), volume);
+                                    volDao.update(volumeStore.getVolumeId(), volume);
                                 }
 
                                 if (volInfo.getSize() > 0) {

server/src/com/cloud/storage/VolumeApiServiceImpl.java

@@ -298,6 +298,8 @@ private boolean validateVolume(Account caller, long ownerId, Long zoneId, String
 
         UriUtils.validateUrl(format, url);
 
+        // check URL existence
+        UriUtils.checkUrlExistence(url);
 
         // Check that the resource limit for secondary storage won't be exceeded
         _resourceLimitMgr.checkResourceLimit(_accountMgr.getAccount(ownerId), ResourceType.secondary_storage, UriUtils.getRemoteSize(url));

utils/src/com/cloud/utils/UriUtils.java

@@ -38,15 +38,18 @@
 
 import org.apache.commons.httpclient.Credentials;
 import org.apache.commons.httpclient.HttpClient;
+import org.apache.commons.httpclient.HttpException;
 import org.apache.commons.httpclient.HttpStatus;
 import org.apache.commons.httpclient.MultiThreadedHttpConnectionManager;
 import org.apache.commons.httpclient.UsernamePasswordCredentials;
 import org.apache.commons.httpclient.auth.AuthScope;
 import org.apache.commons.httpclient.methods.GetMethod;
+import org.apache.commons.httpclient.methods.HeadMethod;
 import org.apache.commons.httpclient.util.URIUtil;
 import org.apache.http.NameValuePair;
 import org.apache.http.client.utils.URIBuilder;
 import org.apache.http.client.utils.URLEncodedUtils;
+
 import org.apache.http.message.BasicNameValuePair;
 import org.apache.log4j.Logger;
 
@@ -273,12 +276,28 @@ public static Pair<String, Integer> validateUrl(String format, String url) throw
                 checkFormat(format, uripath);
             }
             return new Pair<String, Integer>(host, port);
-
         } catch (URISyntaxException use) {
             throw new IllegalArgumentException("Invalid URL: " + url);
         }
     }
 
+    // use http HEAD method to validate url
+    public static void checkUrlExistence(String url) {
+        if (url.toLowerCase().startsWith("http") || url.toLowerCase().startsWith("https")) {
+            HttpClient httpClient = new HttpClient(new MultiThreadedHttpConnectionManager());
+            HeadMethod httphead = new HeadMethod(url);
+            try {
+                if (httpClient.executeMethod(httphead) != HttpStatus.SC_OK) {
+                    throw new IllegalArgumentException("Invalid URL: " + url);
+                }
+            } catch (HttpException hte) {
+                throw new IllegalArgumentException("Cannot reach URL: " + url);
+            } catch (IOException ioe) {
+                throw new IllegalArgumentException("Cannot reach URL: " + url);
+            }
+        }
+    }
+
     // verify if a URI path is compliance with the file format given
     private static void checkFormat(String format, String uripath) {
         if ((!uripath.toLowerCase().endsWith("vhd")) && (!uripath.toLowerCase().endsWith("vhd.zip")) && (!uripath.toLowerCase().endsWith("vhd.bz2")) &&