Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support #4068
Conversation
- Splits commands to create user and grant access on database, the old
statement is no longer supported by MySQL 8.x
- `NO_AUTO_CREATE_USER` is no longer supported by MySQL 8.x so remove
that from db.properties conn parameters
For mysql-server 8.x setup the following changes were added/tested to
make it work with CloudStack in /etc/mysql/mysql.conf.d/mysqld.cnf and
then restart the mysql-server process:
server_id = 1
sql-mode="STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION,ERROR_FOR_DIVISION_BY_ZERO,NO_ZERO_DATE,NO_ZERO_IN_DATE,NO_ENGINE_SUBSTITUTION"
innodb_rollback_on_timeout=1
innodb_lock_wait_timeout=600
max_connections=1000
log-bin=mysql-bin
binlog-format = 'ROW'
default-authentication-plugin=mysql_native_password
Notice the last line above, this is to reset the old password based
authentication used by MySQL 5.x.
Developers can set empty password as follows:
> sudo mysql -u root
ALTER USER 'root'@'localhost' IDENTIFIED BY '';
|
@weizhouapache We'll be adding our changes here, including the python3 support! |
davidjumani
force-pushed
the
adding-centos8-support
branch
from
5fa09d0 to
eb9d639
Compare
|
@davidjumani @shwstppr related PR for Ubuntu 20.04 with likely some overlapping parts - #4069 |
|
@davidjumani I suggest to create separated PR for python2 to python3 upgrade |
davidjumani
force-pushed
the
adding-centos8-support
branch
from
5be4b2e to
f5535b6
Compare
|
@weizhouapache we want to keep them in this PR as CentOS8 ships by default with python3, it may be tricky in some cases to test this PR without adding some python3 support. |
@rhtyd @davidjumani we can upgrade to python3 without any changes for centos8 and ubuntu 20.04, as python3 can be tested on centos7 and ubuntu 18.04/ubuntu 16.04. Comparing with a large PR with many changes, I prefer to create some small/medium PRs with one or two feature/improvement. |
In libvirt repository, there are two related commits
2019-08-23 13:13 Daniel P. Berrangé ● rpm: don't enable socket activation in upgrade if --listen present
2019-08-22 14:52 Daniel P. Berrangé ● remote: forbid the --listen arg when systemd socket activation
In libvirt.spec.in
/bin/systemctl mask libvirtd.socket >/dev/null 2>&1 || :
/bin/systemctl mask libvirtd-ro.socket >/dev/null 2>&1 || :
/bin/systemctl mask libvirtd-admin.socket >/dev/null 2>&1 || :
/bin/systemctl mask libvirtd-tls.socket >/dev/null 2>&1 || :
/bin/systemctl mask libvirtd-tcp.socket >/dev/null 2>&1 || :
Signed-off-by: Abhishek Kumar <[email protected]>
Signed-off-by: Abhishek Kumar <[email protected]>
davidjumani
force-pushed
the
adding-centos8-support
branch
2 times, most recently
from
f1aad4d to
cae1374
Compare
davidjumani
force-pushed
the
adding-centos8-support
branch
from
cae1374 to
67f40b5
Compare
|
@blueorangutan help |
|
@vladimirpetrov I understand these words: "help", "hello", "thanks", "package", "test" Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti'] |
|
@blueorangutan test centos8 kvm-centos8 |
|
@vladimirpetrov a Trillian-Jenkins test job (centos8 mgmt + kvm-centos8) has been kicked to run smoke tests |
|
Env issue failed, rekicked job at the backend (job/acs-pr-trillian/2449/console) |
|
Trillian test result (tid-2450)
|
|
Trillian test result (tid-2452)
|
|
Trillian test result (tid-2451)
|
|
@blueorangutan test centos8 xenserver-71 |
|
@rhtyd a Trillian-Jenkins test job (centos8 mgmt + xenserver-71) has been kicked to run smoke tests |
|
Trillian test result (tid-2457)
|
borisstoyanov
left a comment
borisstoyanov
left a comment
There was a problem hiding this comment.
LGTM, based on marvin results. There are some failures, but I don't think they are related
|
@blueorangutan test centos7 kvm-centos7 |
|
@andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
LGTM Any outstanding issues with tests, will have to be resolved for 4.15 |
|
Thanks @andrijapanicsb @borisstoyanov - agree failing tests are all intermittent failures. Merging this. |
|
Trillian test result (tid-2476)
|
|
@weizhouapache were you able to test this PR against Ubuntu 20.04?. thx |
|
@andrijapanicsb tested some actions and found some issues, see PR #4301 and #4303 |
|
Btw I'm running a custom build of 4.14 on Ubuntu 20.04 on raspberrypi4 using commits from Wei/this PR @andrijapanicsb |
|
@rhtyd @PaulAngus maybe we can work together to make 4.14 on ubuntu 20.04. I have backported some changes in this PR to 4.14, it is tested ok. |
|
not trying to be a smart one, but don't we only implement fixes on 4.14.x release? (i.e. no new features) - or am I confusing things here @weizhouapache ? Otherwise that sounds good (from a user perspective) |
@andrijapanicsb true. 4.14 accepts only bug fixes. so I will not create PR for it. |
|
Management server with Ubuntu 20.04 - LGTM, here is what I've tested:
|
|
It's worth mentioning, that on AMD EPYC CPUs, we had to upgrade Ubuntu kernel to 5.8.1+ in order to resolve a Qemu bug with CPU registers and stuff....where the VM can't be started at all. |
|
(same goes for CentOS 8, had to upgrade to Elrepo 5.8+ kernel to solve the same issues) |
13 participants
Support for CentOS 8 as mgmt/kvm host
Support for Ubuntu 20.04 as mgmt/kvm host
Support for XCP-ng 8.1 as Hypervisor.
Types of changes
Changes have been made in smoke tests to use test template for Xenserver/SCP-ng as XCP-ng 8 and above does not support built-in PV template. Since test template at present does not support iso9660 filesystem, ISO attach-detach test for the VM will skip mounting of the ISO.