Skip to content

Conversation

@davidjumani
Copy link
Contributor

Description

Adding novnc license exclusion to the rat plugin

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

@DaanHoogland
Copy link
Contributor

for dealing with a missed rat issue in #3967 all code is under MPL 2.0 (cat A)

@DaanHoogland DaanHoogland added this to the 4.15.0.0 milestone May 25, 2020
@DaanHoogland
Copy link
Contributor

ai ai, mistake MPL 2.0 is cat B. That does not mean we can't release with this but may have to add a notice to our README.md
I don't think that is in scope for this PR but will have to be dealt with before 4.15. @svenvogel can you keep an eye? (created #4098 )

@svenvogel
Copy link
Contributor

@DaanHoogland yes i will track this and remind to add this in 4.15

@DaanHoogland
Copy link
Contributor

ok, @svenvogel than can you approve of this one and merge?

@rohityadavcloud rohityadavcloud merged commit 38298d1 into apache:master May 26, 2020
@rohityadavcloud rohityadavcloud deleted the add-novnc-license branch May 26, 2020 10:00
soreana pushed a commit to soreana/cloudstack that referenced this pull request Nov 3, 2020
Adding novnc license exclusion to the rat plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants