listphysicalnetworks: Honouring keyword parameter

[davidjumani]

Description

The listPhysicalNetworks API does not consider keyword. This PR fixes it
Required since the UI uses keyword for searches

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

How Has This Been Tested?

Before :

(localhost) 🐱 > list physicalnetworks filter=name, keyword=net2
{
  "count": 2,
  "physicalnetwork": [
    {
      "name": "Sandbox-pnet"
    },
    {
      "name": "phynet2"
    }
  ]
}

After :

(localhost) 🐱 > list physicalnetworks filter=name, keyword=net2
{
  "count": 1,
  "physicalnetwork": [
    {
      "name": "phynet2"
    }
  ]
}

[davidjumani]

@DaanHoogland @rhtyd Would it make sense to change name to return an exact match instead, since in this API, it's treated as keyword would be ?

[davidjumani]

@blueorangutan package

[blueorangutan]

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2456

[davidjumani]

@blueorangutan test

[blueorangutan]

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GabrielBrascher]

Code LGTM

[DaanHoogland]

looks good @davidjumani

@DaanHoogland @rhtyd Would it make sense to change name to return an exact match instead, since in this API, it's treated as keyword would be ?

wouldn't do that, no telling what kind of relying on naming conventions big enterprises have atm.

[blueorangutan]

Trillian test result (tid-3301)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36910 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4511-t3301-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_human_readable_logs.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File