CLOUDSTACK-8157: Add absolute schema references to support MySQL 5.6 better #67
Conversation
|
LGTM. Maybe we could be to put "USE cloud;" (or cloud_usage as applicable) in this file at the beginning, will that help? |
|
Yes, that would also work. I considered it, but since the file works with both cloud and cloud_usage I wasn't sure which one to set as default. |
|
Fair point, merging it. |
This closes #67 Note: This does not change CloudStack's schema but only adds strict reference between foreign keys using database.table syntax. Signed-off-by: Rohit Yadav <[email protected]>
|
Thanks for fixing this Erik @terbolous ! |
|
@bhaisaab This also fails on cloudstack 4.4.2 on debian 7. fix worked. |
|
Good to know @resmo I think I had cherry-picked Erik's fix on 4.3+ branches. |
|
@bhaisaab Seems I overlooked the fix yesterday. All good in 4.4 branch. never mind. |
|
@bhaisaab has this been ported to 4.5 and master ? |
|
ok all good then , just want to make sure we get in the habit of merging these in all forward release branches. |
|
Nux! on [email protected] replies: "Hardcoding" the name is not a very good idea, I understand that under the circumstances is OK, but still. We have to be aware of this detail as there could be people using another name for their DB (I did this in the past). Would upgrades fail for them now? This should be mentioned in the release notes. Lucian |
|
Yes they are :) I generally try to fix things starting from lowest branch where the fix is applicable. |
…d-ips to 4.11.2-leaseweb * commit 'e2e7a24820549b6d714b130591b718d02e3e5d2d': CLSTACK-4040: Integration tests for dedicated IPs CLSTACK-4040: changes in tools/marvin for updateConfiguration and matchResourceCount Refactor CLSTACK-3588: Add option to consider the used public ip (or all ips) in dedicated ip range in resource count CLSTACK-4040: Rename remove.dedicated.ipranges.after.release to delete.dedicated.ip.ranges.in.domain.account.removal Remove record in pod_vlan_map while delete guest ip ranges in Basic zone CLOUDSTACK-8958: allow dedicate ip range to a domain if ips are used by an accout in the domain CLSTACK-308: As Leaseweb we need to add global configuration which indicates whether remove dedicated ip ranges after release in account/domain removal
Custom VM migration form Signed-off-by: Rohit Yadav <[email protected]>
* Prevent addition of duplicate PF rules on scale up and no rules left behind on scale down (#32) * fix missing dependency injection * NSX: Fix concurrency issues on port forwarding rules deletion (#37) * Fix concurrency issues on port forwarding rules deletion * Refactor objectExists * Fix unit test * Fix test * Small fixes * CKS: Externalize control and worker node setup wait time and installation attempts (#38) * NSX: Add shared network support (#41) * NSX: Fix number of physical networks for Guest traffic checks and leftover rules on CKS cluster deletion (#45) * Fix pf rules removal on CKS cluster deletion * Fix check for number of physical networks for guest traffic * Fix unit test * fix logger * NSX: Handle CheckHealthCommand to avoid host disconnection and errors on APIs * NSX: Handle CheckHealthCommand to avoid host disconnection and errors on APIs * Remove unused string * fix logger * Update UDP active monitor to ICMP * Fix NPE on restarting VPC with additional public IPs * NSX / VPC: Reuse Source NAT IP from systemVM range on restarts * CKS: Public IP not found for VPC networks * Externalize retries and inverval for NSX segment deletion (#67) * remove unused import * remove duplicate imports * remove unused import * revert externalizing cks settings * fix test * Refactor log messages * Address comments * Fix issue caused due to forward merge: 90fe1d --------- Co-authored-by: Nicolas Vazquez <[email protected]> Co-authored-by: Rohit Yadav <[email protected]>
6 participants
This should fix the problem some people are seeing with cloudstack-setup-databases complaining about 'No database selected'