fix: remove undeclared dependency on underscore #871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #871 +/- ##
==========================================
- Coverage 91.18% 91.13% -0.06%
==========================================
Files 45 45
Lines 2054 2053 -1
==========================================
- Hits 1873 1871 -2
- Misses 181 182 +1
Continue to review full report at Codecov.
|
raphinesse
force-pushed
the
fix-remove-underscore
branch
from
f34e393 to
86e1aa4
Compare
5 tasks
breautek
approved these changes
Jun 11, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This removes usage of underscore that were introduced after merging #772.
Closes #869
Description
I rewrote the two remaining usages of underscore using plain JS.
Testing
Automated test suite